-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/autocomplete): outside click in Angular zone. #24817
fix(material/autocomplete): outside click in Angular zone. #24817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a unit test for this?
fbda157
to
91c59d6
Compare
I've added test for it. |
91c59d6
to
db3bf3d
Compare
db3bf3d
to
85bb169
Compare
Fixes a bug in Angular Material `autocomplete` when outside click doesn't trigger `changeDetection`. Fixes angular#24811
85bb169
to
d112a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.4` -> `13.3.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.4/13.3.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.4` -> `13.3.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.4/13.3.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1335-bread-bun-2022-04-27) [Compare Source](angular/components@13.3.4...13.3.5) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [68d09ddecd](angular/components@68d09dd) | fix | **overlay:** animations interrupted on repeat insertions ([#​24815](angular/components#24815)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [86a1e8c7be](angular/components@86a1e8c) | fix | **autocomplete:** outside click in Angular zone. ([#​24817](angular/components#24817)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [b16a33dbb2](angular/components@b16a33d) | fix | **mdc-slider:** remove pointerdown passive eve… ([#​24766](angular/components#24766)) | | [6603bd5ec6](angular/components@6603bd5) | fix | **mdc-snack-bar:** avoid querying the DOM on each change detection ([#​24770](angular/components#24770)) | #### Special Thanks Egor Volvachev, Jesse Beder, Kirill Cherkashin, Kristiyan Kostadinov, Paul Gschwendtner, Ruslan Lekhman, Sukka and Wagner Maciel <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1330 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a bug in Angular Material
autocomplete
when outside click doesn't triggerchangeDetection
.Fixes #24811