Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdk/dialog): expand and clean up API #24842

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

crisbeto
Copy link
Member

Adjusts the public API of the CDK dialog based on a recent feedback session by:

  • Expanding DialogRef.restoreFocus to allow CSS selectors and DOM nodes.
  • Changing Dialog.openDialogs, DialogRef.componentInstance and DialogRef.containerInstance to be readonly.
  • Allowing for numbers to be passed in to DialogRef.updateSize.
  • Updating the doc string of DialogRef.updateSize.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Apr 28, 2022
@crisbeto crisbeto requested review from a team and jelbourn as code owners April 28, 2022 07:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Adjusts the public API of the CDK dialog based on a recent feedback session by:
* Expanding `DialogRef.restoreFocus` to allow CSS selectors and DOM nodes.
* Changing `Dialog.openDialogs`, `DialogRef.componentInstance` and `DialogRef.containerInstance` to be readonly.
* Allowing for numbers to be passed in to `DialogRef.updateSize`.
* Updating the doc string of `DialogRef.updateSize`.
@crisbeto crisbeto force-pushed the cdk-dialog-feedback branch from 009010d to 70825a3 Compare April 28, 2022 07:44
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Casts are a little inconvenient but I don't see an easy way without changing much more..

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 28, 2022
@crisbeto crisbeto merged commit 5ab04ec into angular:master Apr 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants