Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Create new comment details view #17087

Closed
26 of 38 tasks
dvdchr opened this issue Aug 26, 2021 · 0 comments
Closed
26 of 38 tasks

Comments: Create new comment details view #17087

dvdchr opened this issue Aug 26, 2021 · 0 comments

Comments

@dvdchr
Copy link
Contributor

dvdchr commented Aug 26, 2021

Ref: pbArwn-2ks-p2

Summary

Create a new Comment Details view, which will be accessible from the Comments and Notifications page. Note that some components will be addressed separately through different issues, and some functionalities may depend on ongoing development. Here's the design from Zeplin:

Screen Shot 2021-08-26 at 16 08 28

Some notes regarding components marked red (going from the top):

  • The edit button will be visually included in this issue, but the functionality depends on Comments: add new Edit view #17000, and may be wired later on. When tapped, the new edit comment view should be shown in full modal presentation.
  • Same as above, the reply button will be visually included in this issue, but the functionality will be addressed through a separate issue.
  • Lastly, the moderation bar will completely be excluded from this and will be addressed through a different issue.

Tasks

Site Comments

Finishing touches

Issues


Notification Comments

  • Refactor notification list to show detail using custom view controllers while maintaining pagination.
  • Refactor Comment Details so it could work with a Notification object.
  • Fetch and populate the data required for comment details, when coming from Notifications. May require changes to WordPressKit.
  • Show the new details view from Notifications.

Finishing touches

  • Review accessibility.
  • Review Tracks.
  • Enable the feature flag for public and update release notes.

Other non-blocking issues

  • Address transition issue when tapping on the Comment header cell, as described in this comment. This is a legacy issue.
  • Fix an issue where the back button's label on the navigation bar is gone after entering split view, as described in this comment. This is a legacy issue.
  • [Low priority] When the orientation change is spammed, content height calculation may get into a state where the web view height is higher than the actual content. Discussion here.
  • Formatted comment contents from self-hosted sites are not rendered with the correct spacing. More details here and here.
  • Fix VoiceOver pathing resets to the top of the screen after reading web view contents. More details here.
@dvdchr dvdchr self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants