Comments: Add method to fetch the latest reply comment ID #17408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger an installable build for these changes by visiting CircleCI here. |
38 tasks
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
4 tasks
ScoutHarris
approved these changes
Nov 2, 2021
| /// | ||
| extension CommentService { | ||
| /// Fetches the current user's latest reply ID for the specified `commentID`. | ||
| /// In case if there are no replies found, the success block will still be called with value 0. |
…ts-service-latest-reply-id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #17087
Depends on #17399, wordpress-mobile/WordPressKit-iOS#463
As titled, this PR extends Comment Service so it could fetch the latest reply ID from a specified comment ID. In the method parameters, I've added
accountServiceto make it testable. As for theAccountServiceusage, the method needs to fetch the current user's dotcom ID to filter returned comments.To test
Since there are no visual changes, make sure all the tests pass.
Regression Notes
Potential unintended areas of impact
n/a. Feature is unreleased.
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a. Feature is unreleased.
What automated tests I added (or what prevented me from doing so)
Added unit tests for the
CommentService.PR submission checklist:
RELEASE-NOTES.txtif necessary.