Comments: Fetch site comments from core V2 endpoint #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs wordpress-mobile/WordPress-iOS#17087
Description
This PR adds a method on
CommentServiceRemoteRESTto fetch site comments through the core v2 endpoint. Since the JSON response structure is a bit different from v1.1,RemoteCommentV2is created to accommodate the differences and mainly to avoid confusion – as some fields in v1.1 are not supported in core v2 (like_count,i_like,can_moderate,i_replied). Conversely, the core v2 endpoint providesauthor, the dotcom ID of the comment's author, and some custom filtering capabilities (e.g. by parent comment ID, or by author dotcom ID).Testing Details
Make sure that all the test passes.
More detailed testing instructions will be shared in the WP-iOS PR later on.
Please check here if your pull request includes additional test coverage.