Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Detail: Fix Delete button not shown or hidden after moderation status update #17463

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Nov 12, 2021

Refs #17087

As titled. After successfully updating the moderation status, refreshData is called to make the Delete button appear/disappear where appropriate.

To test

  • Enable newCommentDetail feature flag.
  • Go to My Site > Comments.
  • Select a pending or approved comment, and update its moderation status to Spam.
  • 🔍 Verify that the Delete button is now shown, along with the notice.
  • Update the moderation status again to pending or approved.
  • 🔍 Verify that the Delete button is now hidden when the notice is shown.

⚠️ NOTE: Auto-merge is enabled! ⚠️


Regression Notes

  1. Potential unintended areas of impact
    n/a. Feature is unreleased.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a. Feature is unreleased.

  3. What automated tests I added (or what prevented me from doing so)
    n/a. Feature is unreleased.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 12, 2021

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ScoutHarris
Copy link
Contributor

make the Delete button appear/disappear where appropriate.

Did I miss this when I implemented moderation? Wow I didn't even notice. Thanks for fixing it!!

@dvdchr dvdchr merged commit b3d9e06 into develop Nov 12, 2021
Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 !!

:shipit:

@dvdchr dvdchr deleted the issue/17087-toggle-delete-button branch November 12, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants