Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Comment: add initial view #17046

Merged
merged 6 commits into from
Aug 19, 2021

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Aug 18, 2021

Ref: #17000

This adds an initial new Edit Comment view.

  • It has sections for each editable field.
  • The actual fields are empty and not editable yet.
  • The nav bar Cancel and Done buttons simply dismiss the view for now.
  • Display is controlled by the newCommentEdit feature flag, which is disabled by default.

To test:


With newCommentEdit enabled:

  • Go to My Site > Comments > Comment details > Edit.
    • Verify the new edit view is displayed.
  • Go to Notifications > Comments > Notification details > Edit.
    • Verify the new edit view is displayed.
iPhone iPad
iphone ipad

With newCommentEdit disabled:

  • Go to My Site > Comments > Comment details > Edit.
    • Verify the existing edit view is displayed.
  • Go to Notifications > Comments > Notification details > Edit.
    • Verify the existing edit view is displayed.

edit_old


Regression Notes

  1. Potential unintended areas of impact
    N/A. Feature is incomplete and disabled.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A. Feature is incomplete and disabled.

  3. What automated tests I added (or what prevented me from doing so)
    N/A. Feature is incomplete and disabled.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 18, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 18, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris added the [Status] Needs Design Review A designer needs to sign off on the implemented design. label Aug 18, 2021
@ScoutHarris ScoutHarris marked this pull request as ready for review August 18, 2021 00:25
@ScoutHarris
Copy link
Contributor Author

ScoutHarris commented Aug 18, 2021

Hey @mattmiklic . I wasn't sure if the new Edit Comment view should be a modal or not. The old one is, and I think that works well, at least on iPad. So I left it that way. But let me know if you think otherwise.

@ScoutHarris ScoutHarris mentioned this pull request Aug 18, 2021
21 tasks
@mattmiklic
Copy link
Member

Hey @mattmiklic . I wasn't sure if the new Edit Comment view should be a modal or not. The old one is, and I think that works well, at least on iPad. So I left it that way. But let me know if you think otherwise.

Yep, that's correct. In the designs I'd mocked it up as a fullscreen modal rather than a sheet, but there's functionally not a big difference and this should be fine.

@ScoutHarris
Copy link
Contributor Author

ScoutHarris commented Aug 18, 2021

Thanks @mattmiklic .

In the designs I'd mocked it up as a fullscreen modal rather than a sheet

Yea, I totally didn't get fullscreen vs sheet 🤦. Sorry! I'll make that change in the next PR.

@ScoutHarris ScoutHarris removed the [Status] Needs Design Review A designer needs to sign off on the implemented design. label Aug 18, 2021
@ScoutHarris ScoutHarris removed the request for review from mattmiklic August 18, 2021 01:32
@mattmiklic
Copy link
Member

No problem; thanks!

@ScoutHarris
Copy link
Contributor Author

Since @dvdchr hasn't reviewed this yet, I went ahead and updated it to show the new edit view in a full screen modal. Note the nav bar background matches what the app uses, not what's in Zeplin.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iPhone and iPad. Everything looks good! 👍 :shipit:

  • Go to My Site > Comments > Comment details > Edit. Verify the new edit view is displayed.
  • Go to Notifications > Comments > Notification details > Edit. Verify the new edit view is displayed.

@ScoutHarris ScoutHarris enabled auto-merge August 19, 2021 15:49
@ScoutHarris
Copy link
Contributor Author

Thanks @dvdchr !

@ScoutHarris ScoutHarris merged commit 145d1ba into develop Aug 19, 2021
@ScoutHarris ScoutHarris deleted the feature/17000-comment_edit_initial_view branch August 19, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants