Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Details: show Delete Permanently only for Trashed comments #17304

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Oct 13, 2021

Ref: #17087 , #17200, #17297

From discussion with @mattmiklic , this enables the Delete Permanently button only for Trashed comments. When trashing a Spam comment, the comment is now marked as Trash instead of deleted.

To test:

  • Enable the newCommentDetail feature.
  • Go to My Site > Comments.
  • Select a Spam comment.
    • Verify Delete Permanently does not appear.
    • Verify selecting Trash moves the comment to the Trashed filter.
  • Select a Trash comment.
    • Verify Delete Permanently does appear.
    • Verify tapping Delete Permanently deletes the comment.

Regression Notes

  1. Potential unintended areas of impact
    N/A. Feature incomplete.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A. Feature incomplete.

  3. What automated tests I added (or what prevented me from doing so)
    N/A. Feature incomplete.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris requested a review from dvdchr October 13, 2021 00:58
@ScoutHarris ScoutHarris marked this pull request as ready for review October 13, 2021 00:58
@ScoutHarris
Copy link
Contributor Author

Hey @dvdchr . With this change, I should be able to DRY the moderation methods in CommentDetailViewController a bit. I'll do that in a follow-up PR.

@ScoutHarris ScoutHarris mentioned this pull request Oct 13, 2021
23 tasks
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ScoutHarris ScoutHarris merged commit 755d7b4 into develop Oct 13, 2021
@ScoutHarris ScoutHarris deleted the feature/17200-delete_only_trash branch October 13, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants