Comment Details: show Delete Permanently only for Trashed comments #17304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #17087 , #17200, #17297
From discussion with @mattmiklic , this enables the
Delete Permanently
button only for Trashed comments. When trashing a Spam comment, the comment is now marked as Trash instead of deleted.To test:
newCommentDetail
feature.Delete Permanently
does not appear.Trash
moves the comment to the Trashed filter.Delete Permanently
does appear.Delete Permanently
deletes the comment.Regression Notes
Potential unintended areas of impact
N/A. Feature incomplete.
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A. Feature incomplete.
What automated tests I added (or what prevented me from doing so)
N/A. Feature incomplete.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.