Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Detail: Fix spacing for views in content cell #17462

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Nov 12, 2021

Refs #17087

As titled, this fixes the spacing for the cell to make it look good in various scenarios. Here are some screenshots:

Description Screenshot
All components are displayed. Full power mode! full
No reaction bar noReactionBar
No moderation bar noModerationBar
Read only replyOnly

⚠️ NOTE: Auto-merge is enabled. ⚠️


To Test

Note: It's easiest for me to modify the values of isReactionEnabled and isModerationEnabled rather than having to switch sites or accounts, to be honest. 😅

  • Enable newCommentDetail feature flag.
  • Go to My Site > Comments.
  • Verify that the content cell is displayed properly when viewed:
    • With moderation capability and ENABLED reactions.
    • With moderation capability and DISABLED reactions. (I'm not sure if this is possible in a real use case, though...)
    • With NO moderation capability and ENABLED reactions.
    • With NO moderation capability and DISABLED reactions.

Regression Notes

  1. Potential unintended areas of impact
    n/a. Feature is unreleased.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a. Feature is unreleased.

  3. What automated tests I added (or what prevented me from doing so)
    n/a. Feature is unreleased.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dvdchr dvdchr merged commit 6946b67 into develop Nov 12, 2021
@dvdchr dvdchr deleted the issue/17087-content-cell-spacing branch November 12, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants