-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment Detail: Add header cell #17095
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dvdchr . Just a couple comments, but otherwise 👍 !
WordPress/Classes/ViewRelated/Comments/CommentHeaderTableViewCell.swift
Outdated
Show resolved
Hide resolved
} | ||
|
||
let readerViewController = ReaderDetailViewController.controllerWithPostID(NSNumber(value: comment.postID), siteID: siteID, isFeed: false) | ||
navigationController?.pushFullscreenViewController(readerViewController, animated: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I was testing on iPad, I noticed an odd behavior which I think is related to pushFullscreenViewController
. The readerViewController
tries to appear full screen, then jumps down to split view. I see this is simply copied behavior from CommentViewController
, and I did confirm this is an existing issue in the app store version. But maybe we can fix it with this feature? (at some point, not in this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense. I'll note this down in #17087 and address this in a separate PR. Thanks! 🙂
Refs #17087
This adds the header cell component for the new comment detail. Some notes:
UITableViewCell
withsubtitle
style (with properly applied text styles for both text label and detail text label). However, since this cell will be reused again later in Comment Threads, I'll create a new class for now to encapsulate all the styling and the.subtitle
cell style.Preview:
To test:
New Comment Detail
feature flag is enabled.Regression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txt
if necessary.