-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment Detail: Add UI for the delete button #17286
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
The delete buttons overall look good! I just want to double-check the red color we're using. When I sampled the color from the screenshot it looks a little different than Red 50 from Color Studio. Can you double-check that it is Red 50? In Dark Mode, we should lighten the red by a shade to make the red text more legible on a dark background, so that should be Red 40. I think the Color Studio reds are already mapped to the semantic |
@mattmiklic Yeah, I've already used the semantic
Noted 👍 . I'll update the color for the dark theme soon. Thanks for the input, sir! Update: Addressed in d9ccadc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Hey @dvdchr . I need this + |
Yep that's probably it. Looks good, thanks for updating the dark mode color as well! |
Refs #17087
This adds the UI for the "Delete Permanently" button. The functionality hasn't been implemented yet, so clicking on it does nothing. A couple of notes:
viewForFooterInSection
, or throughtableView.tableFooterView
and ended up registering it as a table view row.viewForFooterInSection
in.plain
table view style, the footer sticks to the bottom screen. To make sure that the footer stays at the bottom, I'd have to change the table style togrouped
, but this introduces several bits like different cell background colors and additional padding around the top.tableFooterView
, the container doesn't support auto layout (shocking), so I'd have to manually calculate the height of the footer view after the layout pass is completed (probably viasystemLayoutFittingSize
), and then resize the height of thetableFooterView
.separatorInset
) when the cell is placed right before the "Delete Permanently" button. I decided to go with this instead.tableFooterView
is used to hide the cell separator for the last row, but I've noticed that the "Delete Permanently" button is too close to the tab bar. Checking on the designs, I've noticed that there's 45pt of distance between the button and the tab bar, so I've added some height for thetableFooterView
to implement the bottom padding.Lastly, a tiny question for @mattmiklic: here's how the button is currently displayed and highlighted (both in Light and Dark mode). Does this look good for you? Thanks!
To test
New Comment Detail
flag is enabled.Regression Notes
Potential unintended areas of impact
n/a. The feature is still hidden behind a flag.
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a. The feature is still hidden behind a flag.
What automated tests I added (or what prevented me from doing so)
n/a. The feature is still hidden behind a flag.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.