Comment Detail: Create the initial view #17088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can trigger an installable build for these changes by visiting CircleCI here. |
38 tasks
21 tasks
ScoutHarris
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Hey @dvdchr . Just a question about a bit of code that looks unused. Otherwise 👍 !
| // MARK: - Localization | ||
|
|
||
| private extension String { | ||
| static let editBarButtonTitle = NSLocalizedString("Edit", comment: "Edits a Comment") |
There was a problem hiding this comment.
Nope. I forgot to clean it up. Thanks for noticing this! 😄 . Removed in ff524a7.
| CommentViewController *vc = [CommentViewController new]; | ||
| vc.comment = comment; | ||
| Comment *comment = [self.tableViewHandler.resultsController objectAtIndexPath:indexPath]; | ||
| UIViewController *detailViewController; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #17087
Summary
This adds the initial view for comment details, along with the feature flag. Some notes for review:
EditCommentTableViewControllercomponent developed in Comments: add new Edit view #17000To test
Scenario 1: Ensure flow correctness with flag disabled
Scenario 2: The new detail screen should be reachable with flag enabled.
New Comment Detailsfeature flag.Regression Notes
Potential unintended areas of impact
Current comment details is not shown correctly when tapped from My Site > Comments.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested that the implementation is correct.
What automated tests I added (or what prevented me from doing so)
n/a, the feature is behind a disabled flag.
PR submission checklist:
RELEASE-NOTES.txtif necessary.