Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address 26 TODOs in code #45

Closed
chrisklus opened this issue Feb 25, 2022 · 6 comments
Closed

Address 26 TODOs in code #45

chrisklus opened this issue Feb 25, 2022 · 6 comments
Assignees
@samreid
Labels
dev:help-wanted Extra attention is needed priority:3-medium

Comments

@chrisklus
Copy link
Contributor

No description provided.

@chrisklus chrisklus added this to the Classroom prototype milestone Feb 25, 2022
chrisklus added a commit that referenced this issue Feb 27, 2022
@chrisklus
Update TODOs and cleanup, see #45 and #46
d5136e0
chrisklus added a commit that referenced this issue Feb 27, 2022
@chrisklus
Clamp position of median readout node for cards, remove TODOS, see #46 …
4e24e9a 
…and #45
@chrisklus chrisklus mentioned this issue Feb 27, 2022
Closed
chrisklus added a commit that referenced this issue Feb 28, 2022
@chrisklus
Rename NumberCardContainer -> CardNodeContainer.ts, fix relevant nami…
03763d6 
…ng, see #45
@samreid samreid changed the title Address general TODOs in code Address 94 general TODOs in code Mar 4, 2022
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Add PhET-iO instrumentation, see #45
ee1d082
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Update comments, see #45
eb20d38
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Update comments, see #45
fa40acd
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Rename Properties, see #45
9e894a2
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Rename range => physicalRange, see #45
4014603
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Update TODOs, see #45
f8e2e3c
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Convert highlightAnimationIndexProperty to number|null, see #45
0f76294
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Remove unnecessary TODO, see #45
3dc20e0
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Move method to prototype, see #45
edca9c5
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Convert method to emitter, see #45
103b83e
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Remove unnecessary TODO, see #45
d461c2a
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Remove redundant override, see #45
a031454
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Use Animation.then, see #45
ddb1a09
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Remove completed TODO, see #45
0eee9d0
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Mark attributes protected, see #45
f32634c
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Rename DotPlotNode => CASPlotNode, see #45
b52977c
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Use i18n strings, see #45
1a45bd4
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Improve types, see #45
1395276
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Fixed: medianScreen should not need a link here, see #45
c582c6b
samreid added a commit that referenced this issue Mar 4, 2022
@samreid
Rename MedianBarsNode=>MedianBarNode, see #45
0d04d1f
@samreid samreid changed the title Address 94 general TODOs in code Address 75 TODOs in code Mar 4, 2022
samreid added a commit that referenced this issue Apr 30, 2023
@samreid
Address TODOs, see #45
1eaefad
samreid added a commit that referenced this issue Apr 30, 2023
@samreid
Rename maxSoccerBalls and use for the transform y dimension, see #45
1267c6b
samreid added a commit that referenced this issue Apr 30, 2023
@samreid
Remove completed TODO, see #45
83aab56
@samreid samreid changed the title Address 36 TODOs in code Address 26 TODOs in code Apr 30, 2023
@samreid samreid mentioned this issue May 2, 2023
Closed
@zepumph
Copy link
Member

zepumph commented May 2, 2023

Thanks for the ping, there is no reason that a11y-view, low-priority improvements should get in the way of CAV development. Also it is awkward to have TODOs leaking into every sim repo with alt input. So I remove them upon generation over in phetsims/chipper#916

@zepumph zepumph closed this as completed May 2, 2023
@zepumph zepumph reopened this May 2, 2023
marlitas added a commit that referenced this issue May 2, 2023
@marlitas
Explicitly show titleNode area with stroke, see: #45
2452bd6
marlitas added a commit that referenced this issue May 2, 2023
@marlitas
Fix modelViewTransform to size data points on empirically chosen numb…
c3623ed 
…er, see: #45
samreid added a commit that referenced this issue May 2, 2023
@samreid
Center the distance label, see #45
40261b5
samreid added a commit that referenced this issue May 2, 2023
@samreid
Update TODO, see #45
469b44a
samreid added a commit that referenced this issue May 2, 2023
@samreid
Move mean and median prediction nodes to the appropriate screens, see #…
b5bc622 
…45
samreid added a commit that referenced this issue May 3, 2023
@samreid
Add TODO, see #45
b99f58a
samreid added a commit that referenced this issue May 4, 2023
@samreid
Update TODOs, see #45
835bd39
samreid added a commit that referenced this issue May 4, 2023
@samreid
Remove unused file, see #45
5101769
samreid added a commit that referenced this issue May 4, 2023
@samreid
Update TODOs, see #45
f5c1ed6
samreid added a commit that referenced this issue May 4, 2023
@samreid
Update TODOs, see #45
c090d08
@samreid
Copy link
Member

samreid commented May 4, 2023

From today's discussion:

  • We would like to associate remaining TODOs with issues
  • We would like to leave the TODOs in the code (not worrying about double counting).
  • Once each TODO has an issue and the lint rule is turned on, this issue can be closed.

@samreid samreid self-assigned this May 4, 2023
samreid added a commit that referenced this issue May 5, 2023
@samreid
Associate TODOs with issues, see #45
ca1c1cc
samreid added a commit that referenced this issue May 5, 2023
@samreid
Update TODOs, see #45
e46e2d6
samreid added a commit that referenced this issue May 5, 2023
@samreid
Add TODO reference, see #45
f5f4e92
@samreid
Copy link
Member

samreid commented May 5, 2023

In f5f4e92 I also enabled the rule that requires issues in code TODOs. All TODOs have issues, closing.

@samreid samreid closed this as completed May 5, 2023
@samreid samreid mentioned this issue May 7, 2023
Closed
samreid added a commit that referenced this issue May 20, 2023
@samreid
Revert "Remove unused file, see #45"
fd9419f 
This reverts commit 5101769.
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Feb 14, 2024
@samreid
Address TODOs, see phetsims/center-and-variability#45
c7184e9
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Feb 14, 2024
@samreid
Update TODOs, see phetsims/center-and-variability#45
13300a5
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Feb 14, 2024
@samreid
Remove unnecessary TODO, see phetsims/center-and-variability#45
208f954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
dev:help-wanted Extra attention is needed priority:3-medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@samreid @chrisklus @zepumph @amanda-phet @marlitas