Use i18n strings, see #45

phetsims · Mar 4, 2022 · 1a45bd4 · 1a45bd4
1 parent b52977c
commit 1a45bd4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/center-and-spread-strings_en.json b/center-and-spread-strings_en.json
@@ -38,6 +38,9 @@
   "medianEqualsValue": {
     "value": "Median = {{value}}"
   },
+  "plotType": {
+    "value": "Plot Type"
+  },
   "dotPlot": {
     "value": "Dot Plot"
   },

diff --git a/js/centerAndSpreadStrings.ts b/js/centerAndSpreadStrings.ts
@@ -25,6 +25,7 @@ type StringsType = {
   'sortData': string,
   'meanEqualsValue': string,
   'medianEqualsValue': string,
+  'plotType': string,
   'dotPlot': string,
   'linePlot': string,
   'median': string,

diff --git a/js/common/view/GlobalOptionsNode.ts b/js/common/view/GlobalOptionsNode.ts
@@ -15,27 +15,26 @@ import Tandem from '../../../../tandem/js/Tandem.js';
 import PlotType from '../model/PlotType.js';
 import CASConstants from '../CASConstants.js';
 import PhetFont from '../../../../scenery-phet/js/PhetFont.js';
+import centerAndSpreadStrings from '../../centerAndSpreadStrings.js';
 
 class GlobalOptionsNode extends VBox {
   private disposeGlobalOptionsNode: () => void;
 
-  // TODO: Tandem in the options?
+  // TODO: Tandem in the options?  And use tandem in the file?
   constructor( tandem: Tandem ) {
 
-    // TODO: Use translated strings
-    const title = new Text( 'Plot Type', {
+    const title = new Text( centerAndSpreadStrings.plotType, {
       font: new PhetFont( 24 )
     } );
 
     const TEXT_OPTIONS = {
       font: new PhetFont( 18 )
     };
-    // TODO: Use translated strings
     const radioButtonGroup = new VerticalAquaRadioButtonGroup<PlotType>( CASConstants.PLOT_TYPE_PROPERTY, [ {
-      node: new Text( 'Line Plot', TEXT_OPTIONS ),
+      node: new Text( centerAndSpreadStrings.linePlot, TEXT_OPTIONS ),
       value: PlotType.LINE_PLOT
     }, {
-      node: new Text( 'Dot Plot', TEXT_OPTIONS ),
+      node: new Text( centerAndSpreadStrings.dotPlot, TEXT_OPTIONS ),
       value: PlotType.DOT_PLOT
     } ] );