Skip to content

Commit

Permalink
Update TODOs, see #45
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed May 4, 2023
1 parent f5c1ed6 commit c090d08
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
6 changes: 1 addition & 5 deletions js/variability/view/MADInfoNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ export default class MADInfoNode extends VBox {
numeratorText.string = madStrings.join( ' + ' );
denominatorText.string = values.length.toString();

// TODO: If the visually displayed values don't match, adjust a value so it does match. Do this in a stable way
// We would have to update the values over the info bars too, so they are not out of sync
// This sounds very complicated, and could have students see that something like 0.44 got rounded to 0.5
// Maybe if the rounded values don't sum to the rounded total, then add a decimal point and run it again?
// Or use an approx-equals sign?
// TODO: Due to rounding, these values could not add up correctly, see https://github.com/phetsims/center-and-variability/issues/169
const sum = _.reduce( mads, ( sum, mad ) => sum + mad, 0 );
resultNumeratorText.string = Utils.toFixed( sum, 1 );
resultDenominatorText.string = values.length.toString();
Expand Down
1 change: 0 additions & 1 deletion js/variability/view/VariabilityScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export default class VariabilityScreenView extends CAVScreenView {

model.sceneModels.forEach( sceneModel => {

// TODO: VariabilityModel should know the scene models
// TODO: Should the info dialogs be in SceneView? Probably.
// TODO: Only show the one for the selected scene
const infoDialog = new InfoDialog( model, sceneModel as VariabilitySceneModel, {
Expand Down

0 comments on commit c090d08

Please sign in to comment.