Skip to content

Commit

Permalink
Update comments, see #45
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Mar 4, 2022
1 parent ee1d082 commit eb20d38
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions js/common/CASConstants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ const CASConstants = {
CHECKBOX_TEXT_MAX_WIDTH: 120,

// TODO: Should this be declared in main and passed through?
// SR: I prefer that it is treated like a global, but

// SR: I prefer that it is treated like a global. But in other sims I've advocated for passing it through. But here,
// SR: I tried passing it through and it got ugly because it had to be passed to places that seem like they shouldn't need it
// SR: Maybe we should ask dev team?
PLOT_TYPE_PROPERTY: new EnumerationProperty( CASQueryParameters.plotType === 'dotPlot' ? PlotType.DOT_PLOT : PlotType.LINE_PLOT, {
tandem: Tandem.GLOBAL_VIEW.createTandem( 'plotTypeProperty' )
} ),
Expand Down

0 comments on commit eb20d38

Please sign in to comment.