Fixed: medianScreen should not need a link here, see #45

phetsims · Mar 4, 2022 · c582c6b · c582c6b
1 parent 1395276
commit c582c6b
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/js/common/view/MeanOrMedianScreenView.ts b/js/common/view/MeanOrMedianScreenView.ts
@@ -63,15 +63,14 @@ class MeanOrMedianScreenView extends SoccerScreenView {
       maxWidth: 300
     } );
 
-    // TODO: medianScreen should not need a link here
-    CASConstants.PLOT_TYPE_PROPERTY.link( plotType => {
-      if ( options.isMedianScreen ) {
-        titleNode.text = centerAndSpreadStrings.distanceInMeters;
-      }
-      else {
+    if ( options.isMedianScreen ) {
+      titleNode.text = centerAndSpreadStrings.distanceInMeters;
+    }
+    else {
+      CASConstants.PLOT_TYPE_PROPERTY.link( plotType => {
         titleNode.text = plotType === PlotType.LINE_PLOT ? centerAndSpreadStrings.linePlot : centerAndSpreadStrings.dotPlot;
-      }
-    } );
+      } );
+    }
 
     this.accordionBox = new CASAccordionBox( this.model, this.accordionBoxContents, this.topCheckboxPanel,
       titleNode,