Skip to content

Commit

Permalink
Update TODOs, see #45
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Mar 4, 2022
1 parent 4014603 commit f8e2e3c
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions js/common/model/CASModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,7 @@ class CASModel {
readonly isShowingMedianPredictionProperty: BooleanProperty;
readonly cardModelGroup: PhetioGroup<CardModel, [ CASObject ]>; // Only instrumented and enabled if includeCards === true
readonly includeCards: boolean;

readonly maxNumberOfObjects: number;

// TODO: rename to allowedRange or something
readonly physicalRange: Range;

// This is the number that we can still add to the PhetioGroup
Expand All @@ -59,6 +56,8 @@ class CASModel {
readonly meanValueProperty: Property<number | null>;

// TODO: Rename to rangeProperty
// SR: Actually dataRangeProperty seems clearer to me, since it indicates the range of data points
// SR: And we don't want users to get confused about whether it is the physical range of data
readonly dataRangeProperty: Property<Range | null>;
readonly objectChangedEmitter: Emitter<[ CASObject ]>;

Expand Down

0 comments on commit f8e2e3c

Please sign in to comment.