Update TODOs and cleanup, see #45 and #46

phetsims · Feb 27, 2022 · d5136e0 · d5136e0
1 parent be7f1e7
commit d5136e0
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 12 deletions.
diff --git a/js/common/CASConstants.ts b/js/common/CASConstants.ts
@@ -22,6 +22,7 @@ const CASConstants = {
   NUMBER_OF_OBJECTS_LARGE: 20, // the number of objects used on the Spread and Lab screens
 
   // TODO: Should this be declared in main and passed through?
+  // TODO: This should be instrumented
   PLOT_TYPE_PROPERTY: new EnumerationProperty( CASQueryParameters.plotType === 'dotPlot' ? PlotType.DOT_PLOT : PlotType.LINE_PLOT )
 };
 

diff --git a/js/common/view/CASAccordionBox.ts b/js/common/view/CASAccordionBox.ts
@@ -83,7 +83,7 @@ class CASAccordionBox extends AccordionBox {
     backgroundNode.addChild( checkboxPanel );
 
     // TODO for CK: content has no height at time of instantiation, so does not end up in the correct place.
-    // TODO: SR says: Perhaps use x and y instead of center which requires bounds
+    // TODO-UX: SR says: Perhaps use x and y instead of center which requires bounds
     contentNode.centerY = fullBackgroundBounds.centerY;
     backgroundNode.addChild( contentNode );
 

diff --git a/js/common/view/CardNode.ts b/js/common/view/CardNode.ts
@@ -86,6 +86,7 @@ class CardNode extends Node {
       start: () => {
         this.moveToFront();
       },
+      // TODO-UX: This emits for dragging the leftmost card to the left
       drag: ( event, listener ) => this.dragDistanceEmitter.emit( Math.abs( listener.modelDelta.x ) )
     } );
     this.addInputListener( this.dragListener );

diff --git a/js/common/view/DotPlotNode.ts b/js/common/view/DotPlotNode.ts
@@ -4,8 +4,6 @@
  * Shows the dot plot on the "Mean & Median" Screen, including the legends/readouts to the left.
  * The plot is non-interactive.
  *
- * TODO-UX: If the median bar shows at min=median=max=1, the dot plot shifts
- *
  * @author Chris Klusendorf (PhET Interactive Simulations)
  * @author Sam Reid (PhET Interactive Simulations)
  */

diff --git a/js/common/view/GlobalOptionsNode.ts b/js/common/view/GlobalOptionsNode.ts
@@ -22,13 +22,15 @@ class GlobalOptionsNode extends VBox {
   // TODO: Tandem in the options?
   constructor( tandem: Tandem ) {
 
+    // TODO: Use translated strings
     const title = new Text( 'Plot Type', {
       font: new PhetFont( 24 )
     } );
 
     const TEXT_OPTIONS = {
       font: new PhetFont( 18 )
     };
+    // TODO: Use translated strings
     const radioButtonGroup = new VerticalAquaRadioButtonGroup<PlotType>( CASConstants.PLOT_TYPE_PROPERTY, [ {
       node: new Text( 'Line Plot', TEXT_OPTIONS ),
       value: PlotType.LINE_PLOT
@@ -44,16 +46,9 @@ class GlobalOptionsNode extends VBox {
       align: 'left'
     } );
 
-    // @private
-    this.disposeGlobalOptionsNode = () => {
-      radioButtonGroup.dispose();
-    };
+    this.disposeGlobalOptionsNode = () => radioButtonGroup.dispose();
   }
 
-  /**
-   * @public
-   * @override
-   */
   dispose() {
     this.disposeGlobalOptionsNode();
     super.dispose();

diff --git a/js/common/view/MeanOrMedianScreenView.ts b/js/common/view/MeanOrMedianScreenView.ts
@@ -71,7 +71,6 @@ class MeanOrMedianScreenView extends SoccerScreenView {
       }
     } );
 
-    // TODO: CK - float to top of visibleBounds to certain aspect ratio, see https://github.com/phetsims/center-and-spread/issues/50
     this.accordionBox = new CASAccordionBox( this.model, this.accordionBoxContents, this.topCheckboxPanel,
       titleNode,
       this.layoutBounds, {

diff --git a/js/common/view/NumberCardContainer.ts b/js/common/view/NumberCardContainer.ts
@@ -73,6 +73,7 @@ class NumberCardContainer extends Node {
     // Fires if the cardNodeCells may have changed
     this.cardNodeCellsChangedEmitter = new Emitter<[]>();
 
+    // TODO-UX: maybe this should be converted to track distance for individual cards
     // Accumulated card drag distance, for purposes of hiding the drag indicator node
     this.totalDragDistanceProperty = new NumberProperty( 0 );