Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review A11y View #916

Closed
zepumph opened this issue Mar 21, 2020 · 4 comments
Closed

Code review A11y View #916

zepumph opened this issue Mar 21, 2020 · 4 comments
Labels
dev:description

Comments

@zepumph
Copy link
Member

zepumph commented Mar 21, 2020

While working on #740 I found some refactoring and improvements to be done. I will link TODOs here, and try to organize things a bit better in this issue.
@zepumph zepumph self-assigned this Mar 21, 2020
zepumph added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
221f098 
…hipper#916
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
bee2d41 
…hipper#916
zepumph added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
8cba612 
…hipper#916
zepumph added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
465de80 
…hipper#916
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
3b40017 
…hipper#916
zepumph added a commit to phetsims/resistance-in-a-wire that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
aed22e7 
…hipper#916
zepumph added a commit to phetsims/molecules-and-light that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
8a40929 
…hipper#916
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
de3e0aa 
…hipper#916
zepumph added a commit to phetsims/john-travoltage that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
4d66430 
…hipper#916
zepumph added a commit to phetsims/scenery-phet that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
9b9a0a4 
…hipper#916
zepumph added a commit to phetsims/coulombs-law that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
4774002 
…hipper#916
zepumph added a commit to phetsims/example-sim that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
cea0060 
…hipper#916
zepumph added a commit to phetsims/ohms-law that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
04ca027 
…hipper#916
zepumph added a commit to phetsims/friction that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
c1b41cb 
…hipper#916
zepumph added a commit to phetsims/molarity that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
3d73c4c 
…hipper#916
zepumph added a commit that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, #916
0bcad28
zepumph added a commit to phetsims/tambo that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
1d0232f 
…hipper#916
zepumph added a commit to phetsims/sun that referenced this issue Mar 21, 2020
@zepumph
refactor a11y view code, add todos and pull out functions, phetsims/c…
1ef7926 
…hipper#916
@zepumph
Copy link
Member Author

zepumph commented Mar 21, 2020

I pulled functions out into its own script. There are a few todos added as well.

@zepumph
Copy link
Member Author

zepumph commented Mar 31, 2020

  • A11y view should use QueryStringMachine.appendQueryString

@zepumph
Copy link
Member Author

zepumph commented Mar 31, 2020

  • It would be nice if the a11y view javascript was linted. The javascript could be pulled out of the sim a11y template into its own js file. Then it could be linted in chipper. Then the grunt process could add it to the a11y view html template.

zepumph added a commit that referenced this issue Mar 31, 2020
@zepumph
add todos and convert to es6, #916
e4d8bc1
@zepumph zepumph removed their assignment Mar 3, 2023
@samreid samreid mentioned this issue Apr 26, 2023
Closed
zepumph added a commit to phetsims/color-vision that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
19aabfd 
…sims/chipper#916
zepumph added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
8f83516 
…sims/chipper#916
zepumph added a commit to phetsims/john-travoltage that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
d3e73ba 
…sims/chipper#916
zepumph added a commit to phetsims/coulombs-law that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
d4c02c6 
…sims/chipper#916
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
d34637c 
…sims/chipper#916
zepumph added a commit to phetsims/resistance-in-a-wire that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
2deec96 
…sims/chipper#916
zepumph added a commit to phetsims/tambo that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
ddba4c0 
…sims/chipper#916
zepumph added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
eb2a5e4 
…sims/chipper#916
zepumph added a commit to phetsims/greenhouse-effect that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
d4fb479 
…sims/chipper#916
zepumph added a commit to phetsims/mean-share-and-balance that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
7a50e00 
…sims/chipper#916
zepumph added a commit to phetsims/waves-intro that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
14d3b0d 
…sims/chipper#916
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
840f00d 
…sims/chipper#916
zepumph added a commit to phetsims/geometric-optics that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
60b1d9c 
…sims/chipper#916
zepumph added a commit to phetsims/my-solar-system that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
c4dc62a 
…sims/chipper#916
zepumph added a commit to phetsims/scenery-phet that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
0b1da0d 
…sims/chipper#916
zepumph added a commit to phetsims/circuit-construction-kit-dc that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
762a1c6 
…sims/chipper#916
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
73b8eed 
…sims/chipper#916
zepumph added a commit to phetsims/circuit-construction-kit-ac that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
e2ad648 
…sims/chipper#916
zepumph added a commit to phetsims/quadrilateral that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
9255996 
…sims/chipper#916
zepumph added a commit to phetsims/molarity that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
833ddbf 
…sims/chipper#916
zepumph added a commit to phetsims/friction that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
3f88450 
…sims/chipper#916
zepumph added a commit to phetsims/sun that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
8346e6d 
…sims/chipper#916
zepumph added a commit to phetsims/ohms-law that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
e4d7b15 
…sims/chipper#916
zepumph added a commit to phetsims/molecules-and-light that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
797b676 
…sims/chipper#916
zepumph added a commit to phetsims/circuit-construction-kit-ac-virtual-lab that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
6762764 
…sims/chipper#916
zepumph added a commit that referenced this issue May 2, 2023
@zepumph
don't propagate TODOs into generated files, #740 #916
35ccd64
samreid added a commit to phetsims/center-and-variability that referenced this issue May 2, 2023
@samreid
grunt update, see phetsims/chipper#916
a920aa0
jessegreenberg added a commit that referenced this issue Nov 19, 2024
@jessegreenberg
handle TODOs in the a11y view template, see #916
e94e2c9
@jessegreenberg
Copy link
Contributor

The remaining TODOs have been addressed.

A11y view should use QueryStringMachine.appendQueryString

I don't see a precedent for this in other chipper templates so I am going to defer this. I don't see an easy way to bring in QueryStringMachine before sim libraries are loaded.

It would be nice if the a11y view javascript was linted.

Ditto, but this is also desired for other templates and will done through #1405.

For this TODO:

TODO: Work on refining this, and only modifying the elements that change in the PDOM

This requires a new implementation of the a11y view and doesn't seem worthwhile at this time. It is inneffecient as noted in the documentation, but has not been an issue over the last 8 years.

Thanks for your work here @zepumph! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:description
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jessegreenberg @zepumph @marlitas