Skip to content

Commit

Permalink
don't propagate TODOs into generated files, phetsims/chipper#740 phet…
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed May 2, 2023
1 parent c122fd1 commit 8346e6d
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions sun_a11y_view.html
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ <h3>State Descriptions for sun demo</h3>
element.tabIndex = '-1';

// make sure that styling is removed, unless some styling was added just for the copy
// TODO: pdom-style is not used anywhere. Should we keep it? https://github.com/phetsims/chipper/issues/916
if ( element.className !== 'pdom-style' ) {
element.removeAttribute( 'style' );
}
Expand Down Expand Up @@ -382,7 +381,6 @@ <h3>State Descriptions for sun demo</h3>

// This is extremely inefficient every time the document changes, make a new copy, remove
// the visual DOM, and add a new one
// TODO: Work on refining this, and only modifying the elements that change in the PDOM https://github.com/phetsims/chipper/issues/916
copyContainer.innerHTML = '';
const pdomCopy = pdomRoot.cloneNode( true );
pdomCopy.removeAttribute( 'style' );
Expand Down Expand Up @@ -535,14 +533,12 @@ <h3>State Descriptions for sun demo</h3>

// strip the styling from the copied DOM elements

// TODO: why do we do this? Isn't this an element purely in the a11y view? https://github.com/phetsims/chipper/issues/916
alertList.removeAttribute( 'style' );

// get the parent container for the parallel DOM copy and the alert content
const copyContainer = document.getElementById( 'dom-copy-container' );

// once for initial setup
// TODO: do we have to do this? https://github.com/phetsims/chipper/issues/916
setPDOMCopyContent( PDOMRoot, copyContainer );

// update the PDOM copy whenever the sim's PDOM changes
Expand All @@ -561,7 +557,6 @@ <h3>State Descriptions for sun demo</h3>
document.getElementById( 'iframe' ).focus();

// Provide fake focus highlighting to the PDOM copy based on what is actually highlighted in the sim.
// TODO: is polling the best way to do this? If so why 500? https://github.com/phetsims/chipper/issues/916
let previousElement = null;
setInterval( () => {

Expand Down

0 comments on commit 8346e6d

Please sign in to comment.