Clamp position of median readout node for cards, remove TODOS, see #46 …

…and #45
phetsims · Feb 27, 2022 · 4e24e9a · 4e24e9a
1 parent 1ac7193
commit 4e24e9a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/js/common/view/NumberCardContainer.ts b/js/common/view/NumberCardContainer.ts
@@ -249,11 +249,11 @@ class NumberCardContainer extends Node {
         this.medianBarsNode.clear();
       }
 
-      // TODO: Better guard on model.isShowingTopMedianProperty.value
       if ( leftmostCard ) {
-
-        // TODO-UX: Can show median label outside of accordion box for small numbers
         medianReadoutPanel.centerX = getCardPositionX( ( this.cardNodeCells.length - 1 ) / 2 ) + leftmostCard.width / 2;
+        if ( medianReadoutPanel.left < 0 ) {
+          medianReadoutPanel.left = 0;
+        }
         medianReadoutPanel.top = leftmostCard.bottom + MARGIN_Y + 13;
         medianReadoutPanel.visible = model.isShowingTopMedianProperty.value;
       }
@@ -262,6 +262,7 @@ class NumberCardContainer extends Node {
       }
     };
     this.cardNodeCellsChangedEmitter.addListener( updateMedianNode );
+    model.medianValueProperty.link( updateMedianNode );
     model.isShowingTopMedianProperty.link( updateMedianNode );
   }
 

diff --git a/js/common/view/PredictionNode.ts b/js/common/view/PredictionNode.ts
@@ -52,8 +52,6 @@ class PredictionNode extends Node {
     const options = optionize<PredictionNodeOptions, PredictionNodeSelfOptions, NodeOptions>( {
       tandem: Tandem.REQUIRED,
       children: [ arrowNode, shadedSphereNode ],
-
-      // TODO-UX: Touch area
       cursor: 'pointer'
     }, providedOptions );