Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add YTGhost as reviewer of OpenYurt #1256

Merged
merged 1 commit into from
Feb 24, 2023
Merged

add YTGhost as reviewer of OpenYurt #1256

merged 1 commit into from
Feb 24, 2023

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Feb 23, 2023

GitHub Username

@YTGhost

Organization you are requesting membership in

openyurtio

Sponsors

@rambohe-ch

Requirements

  • I have joined in the community [Dingding] and [WeChat]
  • I often attend Openyurt Community Week
  • I have reviewed the [community membership docs]
  • I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
  • I have checked my affiliation in [devstats] (if it's not correct, please fix in [cncf/gitdm])
  • I am actively contributing to 1 or more OpenYurt subprojects

List of your contributions

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1256 (76fb6b0) into master (d4f1f3a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   53.62%   53.62%           
=======================================
  Files         102      102           
  Lines       12751    12751           
=======================================
  Hits         6838     6838           
  Misses       5359     5359           
  Partials      554      554
Flag Coverage Δ
unittests 53.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@YTGhost Thanks for your contributions to OpenYurt community. agree +1

@Congrool
Copy link
Member

Looking forword to your future contributions! agree +1

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the approved approved label Feb 24, 2023
@openyurt-bot openyurt-bot added the lgtm lgtm label Feb 24, 2023
@openyurt-bot openyurt-bot merged commit c912ec8 into openyurtio:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YTGhost @rambohe-ch @Congrool @openyurt-bot