Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal of yurtadm join refactoring #1048

Merged

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Nov 8, 2022

Signed-off-by: HIHIA [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind documentation
/kind design

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #889

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: HIHIA [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind documentation
/kind design

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #889

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Nov 8, 2022
@YTGhost
Copy link
Member Author

YTGhost commented Nov 8, 2022

/assign @rambohe-ch

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #1048 (a415082) into master (23f45da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1048   +/-   ##
=======================================
  Coverage   49.47%   49.47%           
=======================================
  Files          96       96           
  Lines       13054    13054           
=======================================
  Hits         6458     6458           
  Misses       6060     6060           
  Partials      536      536           
Flag Coverage Δ
unittests 49.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YTGhost YTGhost force-pushed the proposal-yurtadm-join-refactoring branch 2 times, most recently from 728f295 to 94d233a Compare November 8, 2022 15:40
@YTGhost YTGhost force-pushed the proposal-yurtadm-join-refactoring branch from 94d233a to a415082 Compare November 9, 2022 04:11
@openyurt-bot openyurt-bot added the approved approved label Nov 9, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 9, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]optimize yurtadm join command
3 participants