Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]optimize yurtadm join command #889

Closed
rambohe-ch opened this issue Jun 17, 2022 · 8 comments · Fixed by #1048 or #1049
Closed

[feature request]optimize yurtadm join command #889

rambohe-ch opened this issue Jun 17, 2022 · 8 comments · Fixed by #1048 or #1049
Assignees
Labels

Comments

@rambohe-ch
Copy link
Member

What would you like to be added:
Code of kubeadm join are imported into OpenYurt by yurtadm join command, how about import kubeadm binary file instead of importing code?
if kubeadm file does not exist, we can install it online. then we need to make sure that kubelet can access kube-apiserver through yurthub and we do not need to restart kubelet and other pods.

Why is this needed:
Compare to import code, using kubeadm binary directly has the following advantages:

  1. It's very easy to follow K8s to update kubeadm version, do not need to maintain the code of kubeadm join in OpenYurt.
  2. reduce the complexity of yurtadm join

others
/kind feature

@rambohe-ch rambohe-ch added kind/feature kind/feature help wanted help wanted labels Jun 17, 2022
@tydra-wang
Copy link
Member

/assign @tydra-wang

@stale
Copy link

stale bot commented Sep 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 15, 2022
@rambohe-ch
Copy link
Member Author

@tydra-wang Do you have any progress for this issue?

@stale stale bot removed the wontfix label Sep 15, 2022
@YTGhost
Copy link
Member

YTGhost commented Sep 20, 2022

If @tydra-wang is not working on this anymore, maybe I can try to take over this job?

@tydra-wang
Copy link
Member

If @tydra-wang is not working on this anymore, maybe I can try to take over this job?

ok!

@rambohe-ch
Copy link
Member Author

If @tydra-wang is not working on this anymore, maybe I can try to take over this job?

@YTGhost Thank you for taking this issue. /assign @YTGhost

@rambohe-ch
Copy link
Member Author

/reopen

@openyurt-bot openyurt-bot reopened this Nov 15, 2022
@openyurt-bot
Copy link
Collaborator

@rambohe-ch: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch rambohe-ch moved this from Done to In Progress in controlplane-v1.2 Nov 15, 2022
Repository owner moved this from In Progress to Done in controlplane-v1.2 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants