Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone to support Kubernetes v1.24 (support CRI compatibility) #1014

Closed
fujitatomoya opened this issue Sep 20, 2022 · 9 comments
Closed
Labels

Comments

@fujitatomoya
Copy link
Contributor

What happened

Just a question about milestone to support Kubernetes v1.24 (support CRI compatibility)

What you expected to happen

Milestone / Development Schedule

How to reproduce it (as minimally and precisely as possible)

Not a problem since Kubernetes v1.24 is not supported.

Anything else we need to know?

We tried to use containerd only w/o dockerd, yurtadm failed to join the cluster from edge.
But with --cri-socket=unix:///run/containerd/containerd.sock seems to make it work to join the edge node to the cluster.

Motivation

  • User likely to want to use latest feature and stability provided by Kubernetes especially cloud infrastructure.
  • Using OpenYurt could be one of the burden to upgrade Kubernetes version since version constrain from OpenYurt.
  • Especially on edge nodes, with extremely restricted resource constraints, it would be probably better to remove docker daemon.

others
/kind question

@fujitatomoya fujitatomoya added the kind/question kind/question label Sep 20, 2022
@fujitatomoya
Copy link
Contributor Author

against, this is just a question, no pressure at all.

@rambohe-ch
Copy link
Member

@fujitatomoya Thank you for raising issue. I think OpenYurt v1.0.0 can support K8s v1.24, but we have not enough energy to verify it. Would you like to check the K8s v1.24 and add the new version for yurtadm join?

by the way, yurtadm join command will be refactored based on kubeadm command, the progress can be found in the issue: #889

@stale
Copy link

stale bot commented Dec 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 20, 2022
@rambohe-ch
Copy link
Member

@fujitatomoya yurtadm join command had been refactored by @YTGhost in the pull request: #1049, and i think K8s v1.24 is supported now.

how about have a try for K8s v1.24 by the newest yurtadm join command?

@fujitatomoya
Copy link
Contributor Author

@rambohe-ch i was trying to verify with kubernetes version 1.24.9 with vanilla ubuntu22.04

root@cluster-master:~# apt-get install -qy --allow-change-held-packages --allow-downgrades kubelet=1.24.9-00 kubectl=1.24.9-00 kubeadm=1.24.9-00

but meeting helm problem to install yurt-app-manager chart.

root@cluster-master:~/yurt-app-manager# helm install --debug --replace yurt-app-manager -n kube-system ./charts/yurt-app-manager --set image.tag=latest
install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /root/yurt-app-manager/charts/yurt-app-manager

client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD nodepools.apps.openyurt.io is already present. Skipping.
client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD uniteddeployments.apps.openyurt.io is already present. Skipping.
client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD yurtappdaemons.apps.openyurt.io is already present. Skipping.
client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD yurtappsets.apps.openyurt.io is already present. Skipping.
client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD yurtingresses.apps.openyurt.io is already present. Skipping.
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" ServiceAccount
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" ClusterRole
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" ClusterRoleBinding
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" Role
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" RoleBinding
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission-create" Job
client.go:128: [debug] creating 1 resource(s)
client.go:540: [debug] Watching for changes to Job yurt-app-manager-admission-create with timeout of 5m0s
client.go:568: [debug] Add/Modify event for yurt-app-manager-admission-create: ADDED
client.go:607: [debug] yurt-app-manager-admission-create: Jobs active: 0, jobs failed: 0, jobs succeeded: 0
client.go:568: [debug] Add/Modify event for yurt-app-manager-admission-create: MODIFIED
client.go:607: [debug] yurt-app-manager-admission-create: Jobs active: 1, jobs failed: 0, jobs succeeded: 0
Error: INSTALLATION FAILED: failed pre-install: timed out waiting for the condition
helm.go:84: [debug] failed pre-install: timed out waiting for the condition
INSTALLATION FAILED
main.newInstallCmd.func2
	helm.sh/helm/v3/cmd/helm/install.go:141
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/[email protected]/command.go:872
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/[email protected]/command.go:990
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/[email protected]/command.go:918
main.main
	helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
	runtime/proc.go:250
runtime.goexit
	runtime/asm_amd64.s:1571

@rambohe-ch
Copy link
Member

@rambohe-ch i was trying to verify with kubernetes version 1.24.9 with vanilla ubuntu22.04

root@cluster-master:~# apt-get install -qy --allow-change-held-packages --allow-downgrades kubelet=1.24.9-00 kubectl=1.24.9-00 kubeadm=1.24.9-00

but meeting helm problem to install yurt-app-manager chart.

root@cluster-master:~/yurt-app-manager# helm install --debug --replace yurt-app-manager -n kube-system ./charts/yurt-app-manager --set image.tag=latest
install.go:192: [debug] Original chart version: ""
install.go:209: [debug] CHART PATH: /root/yurt-app-manager/charts/yurt-app-manager

client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD nodepools.apps.openyurt.io is already present. Skipping.
client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD uniteddeployments.apps.openyurt.io is already present. Skipping.
client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD yurtappdaemons.apps.openyurt.io is already present. Skipping.
client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD yurtappsets.apps.openyurt.io is already present. Skipping.
client.go:128: [debug] creating 1 resource(s)
install.go:151: [debug] CRD yurtingresses.apps.openyurt.io is already present. Skipping.
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" ServiceAccount
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" ClusterRole
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" ClusterRoleBinding
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" Role
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission" RoleBinding
client.go:128: [debug] creating 1 resource(s)
client.go:310: [debug] Starting delete for "yurt-app-manager-admission-create" Job
client.go:128: [debug] creating 1 resource(s)
client.go:540: [debug] Watching for changes to Job yurt-app-manager-admission-create with timeout of 5m0s
client.go:568: [debug] Add/Modify event for yurt-app-manager-admission-create: ADDED
client.go:607: [debug] yurt-app-manager-admission-create: Jobs active: 0, jobs failed: 0, jobs succeeded: 0
client.go:568: [debug] Add/Modify event for yurt-app-manager-admission-create: MODIFIED
client.go:607: [debug] yurt-app-manager-admission-create: Jobs active: 1, jobs failed: 0, jobs succeeded: 0
Error: INSTALLATION FAILED: failed pre-install: timed out waiting for the condition
helm.go:84: [debug] failed pre-install: timed out waiting for the condition
INSTALLATION FAILED
main.newInstallCmd.func2
	helm.sh/helm/v3/cmd/helm/install.go:141
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/[email protected]/command.go:872
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/[email protected]/command.go:990
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/[email protected]/command.go:918
main.main
	helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
	runtime/proc.go:250
runtime.goexit
	runtime/asm_amd64.s:1571

@fujitatomoya It looks like that yurt-app-manager image has caused this error. @kadisi would you be able to take a look for yurt-app-manager?

@YiuTerran
Copy link

Any update here?

@fujitatomoya
Copy link
Contributor Author

@YiuTerran not really, it's been a while, i probably should check with current master to see if the same problem can be observed.

@stale
Copy link

stale bot commented May 31, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 31, 2023
@stale stale bot closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants