Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] yurtadm join fails with k8s version 1.19.4 #1102

Closed
YTGhost opened this issue Dec 19, 2022 · 3 comments · Fixed by #1112
Closed

[BUG] yurtadm join fails with k8s version 1.19.4 #1102

YTGhost opened this issue Dec 19, 2022 · 3 comments · Fixed by #1112
Assignees
Labels
kind/bug kind/bug

Comments

@YTGhost
Copy link
Member

YTGhost commented Dec 19, 2022

What happened:
image
When we use k8s version v1.19.4, yurtadm join will fail

What you expected to happen:
yurtadm join has no exceptions and can join nodes smoothly

How to reproduce it (as minimally and precisely as possible):
When refactoring the yurtadm join, we constructed the JoinConfiguration file as the configuration file for calling kubeadm, which apiVersion is kubeadm.k8s.io/v1beta3. According to https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta3/, v1beta3 is only supported for v1.22.x and above.

Anything else we need to know?:

Environment:

  • OpenYurt version:
  • Kubernetes version (use kubectl version):v1.19.4
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

others

/kind bug

@YTGhost YTGhost added the kind/bug kind/bug label Dec 19, 2022
@YTGhost
Copy link
Member Author

YTGhost commented Dec 19, 2022

@rambohe-ch I think we need to switch the apiVersion of the JoinConfiguration file to v1beta2 so that it supports v1.15.x and above, WDYT?
Another question is whether we still need to be compatible with k8s below v1.15.x. If so, perhaps we should dynamically switch the apiVersion used depending on the k8s version of the cluster.

@rambohe-ch
Copy link
Member

rambohe-ch commented Dec 20, 2022

@rambohe-ch I think we need to switch the apiVersion of the JoinConfiguration file to v1beta2 so that it supports v1.15.x and above, WDYT? Another question is whether we still need to be compatible with k8s below v1.15.x. If so, perhaps we should dynamically switch the apiVersion used depending on the k8s version of the cluster.

@YTGhost I think we only need to support K8s with versions larger than v1.18, and don't need to consider any smaller version.

maybe it's a good idea to switch the apiVersion of JoinConfiguration according to K8s version.

@YTGhost
Copy link
Member Author

YTGhost commented Dec 20, 2022

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug
Projects
None yet
2 participants