Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Bump golang from 1.16 to 1.17 #1190

Closed
YTGhost opened this issue Feb 6, 2023 · 3 comments · Fixed by #1192
Closed

[feature request] Bump golang from 1.16 to 1.17 #1190

YTGhost opened this issue Feb 6, 2023 · 3 comments · Fixed by #1192
Assignees
Labels
kind/feature kind/feature

Comments

@YTGhost
Copy link
Member

YTGhost commented Feb 6, 2023

What would you like to be added:

Why is this needed:
fix #1059 need to bump ginkgo from 2.1.4 to 2.8.0, ginkgo's dependencies require go1.17.

others
/kind feature

@YTGhost YTGhost added the kind/feature kind/feature label Feb 6, 2023
@YTGhost
Copy link
Member Author

YTGhost commented Feb 6, 2023

Is there any obstacle to upgrading go version to 1.17? @rambohe-ch

@rambohe-ch
Copy link
Member

Is there any obstacle to upgrading go version to 1.17? @rambohe-ch

@YTGhost Thank you for raising issue. There is no obstacle to upgrading go version to 1.17, and in fact, we have used golang v1.17 to build OpenYurt components. take yurthub as a example: https://github.com/openyurtio/openyurt/blob/master/hack/dockerfiles/Dockerfile.yurthub#L3

would you be able to make a pull request to upgrade go version to 1.17?

@YTGhost
Copy link
Member Author

YTGhost commented Feb 6, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants