Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge yurtctl to e2e #1219

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Feb 9, 2023

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1059

Special notes for your reviewer:

@Congrool

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1059

Special notes for your reviewer:

@Congrool

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1219 (8a6aa6f) into master (13a721a) will increase coverage by 1.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
+ Coverage   52.24%   53.57%   +1.32%     
==========================================
  Files         106      100       -6     
  Lines       13880    12584    -1296     
==========================================
- Hits         7252     6742     -510     
+ Misses       5980     5294     -686     
+ Partials      648      548     -100     
Flag Coverage Δ
unittests 53.57% <ø> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/e2e/cmd/init/converter.go
test/e2e/cmd/init/init.go
test/e2e/cmd/init/kindoperator.go
test/e2e/cmd/init/lock/lock.go
test/e2e/cmd/init/util/kubernetes/apply_addons.go
test/e2e/cmd/init/util/kubernetes/util.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@Congrool PTAL

hack/make-rules/run-e2e-tests.sh Outdated Show resolved Hide resolved
test/e2e/cmd/cmd.go Outdated Show resolved Hide resolved
test/e2e/cmd/e2e/e2e.go Outdated Show resolved Hide resolved
@YTGhost
Copy link
Member Author

YTGhost commented Feb 13, 2023

@Congrool PTAL

Copy link
Member

@Congrool Congrool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contribution!

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit 7488bda into openyurtio:master Feb 14, 2023
@YTGhost YTGhost mentioned this pull request Feb 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]merge yurtctl init test command into yurtadm tool
4 participants