-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revise proposal docs #1013
revise proposal docs #1013
Conversation
@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @YTGhost! It looks like this is your first PR to openyurtio/openyurt 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
=======================================
Coverage 47.60% 47.60%
=======================================
Files 89 89
Lines 12548 12548
=======================================
Hits 5974 5974
Misses 6059 6059
Partials 515 515
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@YTGhost please fix misspell errors. |
Signed-off-by: HIHIA <[email protected]>
@rambohe-ch PTAL |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, YTGhost The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: HIHIA <[email protected]> Signed-off-by: HIHIA <[email protected]>
Signed-off-by: HIHIA [email protected]
What type of PR is this?
What this PR does / why we need it:
After #852, some related doc need to update.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note