Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise proposal docs #1013

Merged
merged 1 commit into from
Sep 28, 2022
Merged

revise proposal docs #1013

merged 1 commit into from
Sep 28, 2022

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Sep 20, 2022

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind documentation

What this PR does / why we need it:

After #852, some related doc need to update.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind documentation

What this PR does / why we need it:

After #852, some related doc need to update.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Sep 20, 2022
@openyurt-bot
Copy link
Collaborator

Welcome @YTGhost! It looks like this is your first PR to openyurtio/openyurt 🎉

@YTGhost YTGhost closed this Sep 20, 2022
@YTGhost YTGhost reopened this Sep 21, 2022
@openyurt-bot openyurt-bot added the approved approved label Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1013 (8fdc127) into master (ba10718) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1013   +/-   ##
=======================================
  Coverage   47.60%   47.60%           
=======================================
  Files          89       89           
  Lines       12548    12548           
=======================================
  Hits         5974     5974           
  Misses       6059     6059           
  Partials      515      515           
Flag Coverage Δ
unittests 47.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@YTGhost please fix misspell errors.

@YTGhost
Copy link
Member Author

YTGhost commented Sep 27, 2022

@rambohe-ch PTAL

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 28, 2022
@openyurt-bot openyurt-bot merged commit eb5f406 into openyurtio:master Sep 28, 2022
lorrielau pushed a commit to lorrielau/openyurt that referenced this pull request Sep 30, 2022
@YTGhost YTGhost mentioned this pull request Feb 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants