Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] openyurt components crd naming convention and style #852

Assignees
Labels
kind/feature kind/feature kind/good-first-issue kind/good-first-issue

Comments

@huiwq1990
Copy link
Member

huiwq1990 commented May 26, 2022

What would you like to be added:

Currently, openyurt components have different naming convention and style, like yurt-app-manager's UnderScoreCase and yurt-edgex-manager's AllLowCase. It's better use CamelCase, like k8s's

	ImagePullSecrets []LocalObjectReference `json:"imagePullSecrets,omitempty" patchStrategy:"merge" patchMergeKey:"name" protobuf:"bytes,15,rep,name=imagePullSecrets"`

Why is this needed:

It's more canonicalization and reduce crd upgrade risk.

others
/kind feature

@huiwq1990 huiwq1990 added the kind/feature kind/feature label May 26, 2022
@rambohe-ch
Copy link
Member

@huiwq1990 Very appreciate for your issue, and i agree with your suggestion to conform for K8s naming convention.
i think we can revise the CRD naming convention in OpenYurt v0.8.0.

@rambohe-ch rambohe-ch added the kind/good-first-issue kind/good-first-issue label Jun 22, 2022
@YTGhost
Copy link
Member

YTGhost commented Sep 16, 2022

Does this feature still need to be done? I think I can do it.

@rambohe-ch
Copy link
Member

Does this feature still need to be done? I think I can do it.

@YTGhost I think nobody is focusing on this issue, and i'm glad that you can pick up this issue.
/assign @YTGhost

@YTGhost
Copy link
Member

YTGhost commented Sep 18, 2022

Does this feature still need to be done? I think I can do it.

@YTGhost I think nobody is focusing on this issue, and i'm glad that you can pick up this issue. /assign @YTGhost

PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature kind/good-first-issue kind/good-first-issue
Projects
No open projects
Status: Done
3 participants