Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

crd naming optimization #117

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Sep 18, 2022

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

crd naming optimization

Which issue(s) this PR fixes:

Fixes openyurtio/openyurt#852

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #117 (1b73cb7) into master (b22ba35) will not change coverage.
The diff coverage is n/a.

❗ Current head 1b73cb7 differs from pull request most recent head 8bb7568. Consider uploading reports for the commit 8bb7568 to get more accurate results

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   37.37%   37.37%           
=======================================
  Files          42       42           
  Lines        4776     4776           
=======================================
  Hits         1785     1785           
  Misses       2752     2752           
  Partials      239      239           
Flag Coverage Δ
unittests 37.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@zzguang PTAL

@zzguang
Copy link
Member

zzguang commented Sep 19, 2022

Generally, it looks good to me except one word of "ingressIps", I am not sure whether "ingressIPs" is better, please check it, thanks!

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Sep 19, 2022
@YTGhost
Copy link
Member Author

YTGhost commented Sep 19, 2022

Generally, it looks good to me except one word of "ingressIps", I am not sure whether "ingressIPs" is better, please check it, thanks!

Yep, you're right. Please take another look

@zzguang
Copy link
Member

zzguang commented Sep 19, 2022

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YTGhost, zzguang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved lgtm lgtm labels Sep 19, 2022
@openyurt-bot openyurt-bot merged commit dfea469 into openyurtio:master Sep 19, 2022
@zzguang
Copy link
Member

zzguang commented Sep 19, 2022

@YTGhost , Since the CRD naming is optimized, could you please update the related doc accordingly? Thanks!

@YTGhost
Copy link
Member Author

YTGhost commented Sep 19, 2022

@YTGhost , Since the CRD naming is optimized, could you please update the related doc accordingly? Thanks!

ok

@YTGhost
Copy link
Member Author

YTGhost commented Sep 20, 2022

@YTGhost , Since the CRD naming is optimized, could you please update the related doc accordingly? Thanks!

Hi, I'm not very familiar with it, so I'd like to ask if it refers to the documentation here?https://github.com/openyurtio/openyurt.io

@rambohe-ch
Copy link
Member

@YTGhost , Since the CRD naming is optimized, could you please update the related doc accordingly? Thanks!

Hi, I'm not very familiar with it, so I'd like to ask if it refers to the documentation here?https://github.com/openyurtio/openyurt.io

@YTGhost yes, all official documents are hosted in this repo, and can be accessed from website: https://openyurt.io.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] openyurt components crd naming convention and style
4 participants