-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 37.37% 37.37%
=======================================
Files 42 42
Lines 4776 4776
=======================================
Hits 1785 1785
Misses 2752 2752
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@zzguang PTAL |
Generally, it looks good to me except one word of "ingressIps", I am not sure whether "ingressIPs" is better, please check it, thanks! |
Signed-off-by: HIHIA <[email protected]>
Yep, you're right. Please take another look |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YTGhost, zzguang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@YTGhost , Since the CRD naming is optimized, could you please update the related doc accordingly? Thanks! |
ok |
Hi, I'm not very familiar with it, so I'd like to ask if it refers to the documentation here?https://github.com/openyurtio/openyurt.io |
@YTGhost yes, all official documents are hosted in this repo, and can be accessed from website: https://openyurt.io. |
Signed-off-by: HIHIA [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
crd naming optimization
Which issue(s) this PR fixes:
Fixes openyurtio/openyurt#852
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note