Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make lint bug #1224

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: make lint bug #1224

merged 1 commit into from
Feb 10, 2023

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Feb 10, 2023

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When I upgraded the golangci-lint version from 1.31.0 to 1.40.0, the problem was solved

Which issue(s) this PR fixes:

Fixes #1223

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Signed-off-by: HIHIA <[email protected]>
@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When I upgraded the golangci-lint version from 1.31.0 to 1.40.0, the problem was solved

Which issue(s) this PR fixes:

Fixes #1223

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Feb 10, 2023
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1224 (45bf8b5) into master (610d986) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1224   +/-   ##
=======================================
  Coverage   52.24%   52.24%           
=======================================
  Files         106      106           
  Lines       13880    13880           
=======================================
  Hits         7252     7252           
  Misses       5980     5980           
  Partials      648      648           
Flag Coverage Δ
unittests 52.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot openyurt-bot added the approved approved label Feb 10, 2023
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 13a721a into openyurtio:master Feb 10, 2023
@YTGhost YTGhost mentioned this pull request Feb 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] make lint error
3 participants