Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add ignore preflight errors to adapt kubeadm before version 1.23.0 #1092

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Dec 7, 2022

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When the refactored yurtadm join running, we create the yaml file of YurtHub Static Pod to the /etc/kubernetes/manifests folder before calling kubeadm join.
In the case of kubeadm join before 1.23.0, the /etc/kubernetes/manifests folder is checked to see if it has been created. So we need to add a preflight error ignored for this folder to adapt to the situation.

Which issue(s) this PR fixes:

Fixes #1091

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When the refactored yurtadm join running, we create the yaml file of YurtHub Static Pod to the /etc/kubernetes/manifests folder before calling kubeadm join.
In the case of kubeadm join before 1.23.0, the /etc/kubernetes/manifests folder is checked to see if it has been created. So we need to add a preflight error ignored for this folder to adapt to the situation.

Which issue(s) this PR fixes:

Fixes #1091

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Dec 7, 2022
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Dec 7, 2022
@YTGhost
Copy link
Member Author

YTGhost commented Dec 7, 2022

/assign @rambohe-ch

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1092 (f6f61c1) into master (cf02f61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1092   +/-   ##
=======================================
  Coverage   53.07%   53.07%           
=======================================
  Files          94       94           
  Lines       12653    12653           
=======================================
  Hits         6716     6716           
  Misses       5367     5367           
  Partials      570      570           
Flag Coverage Δ
unittests 53.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot openyurt-bot added the approved approved label Dec 7, 2022
@rambohe-ch
Copy link
Member

@YTGhost Thanks for posting pull request to improve yurtadm join command.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Dec 7, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit c25be06 into openyurtio:master Dec 7, 2022
@YTGhost YTGhost mentioned this pull request Feb 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The yurtadm join command encountered a preflight check error
3 participants