-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: add ignore preflight errors to adapt kubeadm before version 1.23.0 #1092
Conversation
….23.0 Signed-off-by: HIHIA <[email protected]>
@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rambohe-ch |
Codecov Report
@@ Coverage Diff @@
## master #1092 +/- ##
=======================================
Coverage 53.07% 53.07%
=======================================
Files 94 94
Lines 12653 12653
=======================================
Hits 6716 6716
Misses 5367 5367
Partials 570 570
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@YTGhost Thanks for posting pull request to improve yurtadm join command. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, YTGhost The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: HIHIA [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
When the refactored
yurtadm join
running, we create the yaml file of YurtHub Static Pod to the/etc/kubernetes/manifests
folder before callingkubeadm join
.In the case of
kubeadm join
before1.23.0
, the/etc/kubernetes/manifests
folder is checked to see if it has been created. So we need to add a preflight error ignored for this folder to adapt to the situation.Which issue(s) this PR fixes:
Fixes #1091
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note