Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for a moment before start to clean up yurt-e2e-test namespace #1063

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Nov 17, 2022

Signed-off-by: HIHIA [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

After #1060, 10s doesn't seem to be enough.

Which issue(s) this PR fixes:

Fixes #1054

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: HIHIA [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug

What this PR does / why we need it:

After https://github.com/openyurtio/openyurt/pull/1060/files, 10s doesn't seem to be enough.

Which issue(s) this PR fixes:

Fixes #1054

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Nov 17, 2022
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #1063 (f2c34ef) into master (9d97567) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1063   +/-   ##
=======================================
  Coverage   50.04%   50.04%           
=======================================
  Files          96       96           
  Lines       12841    12841           
=======================================
  Hits         6426     6426           
  Misses       5879     5879           
  Partials      536      536           
Flag Coverage Δ
unittests 50.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot openyurt-bot added size/S size/S 10-29 and removed size/XS size/XS: 0-9 labels Nov 20, 2022
@YTGhost YTGhost changed the title extend timeout period when retry deleting test ns wait for a moment before start to clean up yurt-e2e-test namespace Nov 20, 2022
@YTGhost
Copy link
Member Author

YTGhost commented Nov 20, 2022

@Congrool PTAL

@Congrool
Copy link
Member

/lgtm
Thanks

@rambohe-ch
Copy link
Member

/approve

@openyurt-bot openyurt-bot added the approved approved label Nov 21, 2022
@openyurt-bot openyurt-bot merged commit d5ffeda into openyurtio:master Nov 21, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YTGhost YTGhost mentioned this pull request Feb 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autonomy test failed for deleting namespace
4 participants