Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry deleting test ns after reconnecting cloud node #1060

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

Congrool
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

After execution of docker reconnect to reconnect the cloud node, there may have a little before the cloud node can be actually visited. So, we'd better keep retry when deleting namespace.

Which issue(s) this PR fixes:

Fixes #1054

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@Congrool: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

After execution of docker reconnect to reconnect the cloud node, there may have a little before the cloud node can be actually visited. So, we'd better keep retry when deleting namespace.

Which issue(s) this PR fixes:

Fixes #1054

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1060 (87e8877) into master (45266e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   49.47%   49.47%           
=======================================
  Files          96       96           
  Lines       13056    13056           
=======================================
  Hits         6460     6460           
  Misses       6060     6060           
  Partials      536      536           
Flag Coverage Δ
unittests 49.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot openyurt-bot added size/S size/S 10-29 and removed size/XS size/XS: 0-9 labels Nov 16, 2022
@Congrool
Copy link
Member Author

I think it's fixed, PTAL @rambohe-ch

We can rerun it several times to ensure it.

@openyurt-bot openyurt-bot added the approved approved label Nov 16, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autonomy test failed for deleting namespace
3 participants