-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Refactor SparkQueryDispatcher (#2636) #2668
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (opensearch-project#1349) Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit 672c72f) Co-authored-by: GabeFernandez310 <[email protected]>
…search-project#1351) Added WeekOfYear As An Alias To Week Function Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit 114e02a) Co-authored-by: GabeFernandez310 <[email protected]>
…1344) (opensearch-project#1350) Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit d9114f5) Co-authored-by: GabeFernandez310 <[email protected]>
…1353) (opensearch-project#1355) * Capture IndexNotFoundException and re-throw directly Signed-off-by: Chen Dai <[email protected]> * Add IT Signed-off-by: Chen Dai <[email protected]> --------- Signed-off-by: Chen Dai <[email protected]> (cherry picked from commit 76a8d29) Co-authored-by: Chen Dai <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]> (cherry picked from commit de40f42)
…ject#1369) * Add release notes for 2.6.0 Signed-off-by: Rupal Mahajan <[email protected]> * Remove incorrect links Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit 73305e9) Co-authored-by: Rupal Mahajan <[email protected]>
* Integ Test Refactoring Signed-off-by: Vamsi Manohar <[email protected]>
…pensearch-project#1389) * Refactor AWSSigV4 auth to support different AWSCredentialProviders Signed-off-by: Vamsi Manohar <[email protected]> * Added unit tests for sts assume role credentials provider Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]>
…pensearch-project#1380) (opensearch-project#1381) Signed-off-by: Chen Dai <[email protected]> (cherry picked from commit 71d8604) Co-authored-by: Chen Dai <[email protected]>
Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]>
…h-project#1404) Signed-off-by: MaxKsyunz <[email protected]> (cherry picked from commit 6108ca1) Co-authored-by: Max Ksyunz <[email protected]>
… (opensearch-project#1410) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 0a02009)
…rface (opensearch-project#1408) (opensearch-project#1414) * Added new interface methods in DataSourceService and DataSourceMetadataStorage Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 98fb969) Co-authored-by: vamsi-amazon <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
…opensearch-project#1354) (opensearch-project#1424) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit bcfda37) Co-authored-by: Peng Huo <[email protected]>
…-project#1434) (opensearch-project#1437) * Updated SINH function to V2 engine, added documentation, unit/IT tests Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit c9f96fb) Co-authored-by: Matthew Wells <[email protected]>
…-project#1433) (opensearch-project#1439) Added RINT to V2 engine, updated documentation, added unit and IT tests Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit 7220cfe) Co-authored-by: Matthew Wells <[email protected]>
…pensearch-project#1438) * Added Tests * Added Implementation And Documentation * Added Integration Test And Fixed Checkstyle * Addressed PR Comments * Fixed Checkstyle * Added Tests And Modified Docs * Fixed formatNanos Helper Function * Temporarily Removed Failing Tests * Fixed Nanoseconds Float/Double Imprecision Issues * Fixed Checkstyle * Added Tests * Altered Implementation To Use BigDecimal --------- Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit aa7f90e) Co-authored-by: GabeFernandez310 <[email protected]>
…earch-project#1440) * Added Tests * Added Implementation * Added Documentation * Fixed IT Test * Adjusted IT test * Fixed Implementation for Time And Unit Tests * Addressed PR Comments * Cleaned WeekdayTest File * Fixed Docs * Fixed Doctest * Removed Unneeded Function --------- Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit 4f9f5ca) Co-authored-by: GabeFernandez310 <[email protected]>
…pensearch-project#1445) * Add `YEARWEEK` Function To OpenSearch SQL * Added Tests Signed-off-by: GabeFernandez310 <[email protected]> * Added Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Added Documentation Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Tests Signed-off-by: GabeFernandez310 <[email protected]> * Addressed PR Comments Signed-off-by: GabeFernandez310 <[email protected]> * Cleaned YearweekTest File Signed-off-by: GabeFernandez310 <[email protected]> * Added Tests and Fixed Docs Signed-off-by: GabeFernandez310 <[email protected]> * Added And Modified Unit Tests Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Jacoco In Core Signed-off-by: GabeFernandez310 <[email protected]> * Reworked convertWeekModeFromMySqlToJava Function Signed-off-by: GabeFernandez310 <[email protected]> * Refactored To Remove Extra Function Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Magic Number Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit 03e4f97)
) (opensearch-project#1443) * Add `EXTRACT` Function To OpenSearch SQL Plugin * Added Basic Tests Signed-off-by: GabeFernandez310 <[email protected]> * Added Lexer And Parser Language Signed-off-by: GabeFernandez310 <[email protected]> * Added Implementation And Fixed Tests Signed-off-by: GabeFernandez310 <[email protected]> * Added Documentation Signed-off-by: GabeFernandez310 <[email protected]> * Modified Implementation And Tests Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Checkstyle Issues Signed-off-by: GabeFernandez310 <[email protected]> * Added Javadoc comments and Tests Signed-off-by: GabeFernandez310 <[email protected]> * Changed Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Changed A Test Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Integration Tests Signed-off-by: GabeFernandez310 <[email protected]> * Refactored Extract Tests Into New File Signed-off-by: GabeFernandez310 <[email protected]> * Refactored Tests Signed-off-by: GabeFernandez310 <[email protected]> * Renamed Rule In Parser Signed-off-by: GabeFernandez310 <[email protected]> * Fixed AstExpressionBuilder Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> * Removed Unneeded Code And Added Parser Test Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit 87018c6)
opensearch-project#1444) * Add `STR_TO_DATE` Function To The SQL Plugin. * Added Tests Signed-off-by: GabeFernandez310 <[email protected]> * Added Empty Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Added Partially Working Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Cleaned Up Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Modified Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Modified IT Test Signed-off-by: GabeFernandez310 <[email protected]> * Added Documentation Signed-off-by: GabeFernandez310 <[email protected]> * Added Unit Tests Signed-off-by: GabeFernandez310 <[email protected]> * Altered Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Reworked Implementation To Always Return Datetime Signed-off-by: GabeFernandez310 <[email protected]> * Addressed PR Comments Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Some Checkstyle Issues Signed-off-by: GabeFernandez310 <[email protected]> * Cleaned Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Supported Function Properties Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Checkstyle Signed-off-by: GabeFernandez310 <[email protected]> * Removed Unneeded Function Signed-off-by: GabeFernandez310 <[email protected]> * Cleaned Implementation and Added IT Test Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Code Coverage and Implementation Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> * Cleaned Implementation Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit 40336d4)
) (opensearch-project#1447) * Add The `TO_SECONDS` Function To The SQL Plugin (opensearch-project#232) * Added Basic Tests Signed-off-by: GabeFernandez310 <[email protected]> * Added IT Test Signed-off-by: GabeFernandez310 <[email protected]> * Added Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Changed Integration Tests Signed-off-by: GabeFernandez310 <[email protected]> * Added Test For Time Type Signed-off-by: GabeFernandez310 <[email protected]> * Added Documentation Signed-off-by: GabeFernandez310 <[email protected]> * Addressed PR Comments Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Docs and Implementation Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Checkstyle Signed-off-by: GabeFernandez310 <[email protected]> * Changed DateTimeFormatter Priority Signed-off-by: GabeFernandez310 <[email protected]> * Added More Formatters Signed-off-by: GabeFernandez310 <[email protected]> * Updated Docs Signed-off-by: GabeFernandez310 <[email protected]> * Reworked Implementation For Formatters Signed-off-by: GabeFernandez310 <[email protected]> * Cleanup Signed-off-by: GabeFernandez310 <[email protected]> * Added Test Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Implementation And Code Coverage Signed-off-by: GabeFernandez310 <[email protected]> * Changed getFormatter Function Signed-off-by: GabeFernandez310 <[email protected]> * Added Comments Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> * Removed Unneeded Code Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit d38a6ec)
…ensearch-project#1448) * Updated Arithmetic functions from old engine to new engine (opensearch-project#235) * Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit bc39346) Co-authored-by: Matthew Wells <[email protected]>
…rch-project#1442) * Added SIGNUM function to V2 engine (opensearch-project#241) * Added SIGNUM function to V2 engine, updated documentation, added unit/IT tests Signed-off-by: Matthew Wells <[email protected]> * fixed merge mistake Signed-off-by: Matthew Wells <[email protected]> * fixed merging error Signed-off-by: Matthew Wells <[email protected]> --------- Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit 6496692) Co-authored-by: Matthew Wells <[email protected]>
…ect#1451) (opensearch-project#1453) * Add `TIMESTAMPADD` Function To OpenSearch SQL Plugin Added Testing And Implementation for TIMESTAMPADD Signed-off-by: GabeFernandez310 <[email protected]> * Fixed Formatting Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit 7b83e50) Co-authored-by: GabeFernandez310 <[email protected]>
…ion (opensearch-project#1314) (opensearch-project#1455) * Rework on `OpenSearchDataType`: parse, store and use mapping information (opensearch-project#180) Rework on `OpenSearchDataType`: * Add data types for those classes are not defined in `ExprCoreType`. * Address Bit-Quill#180 (comment) * Remove `TextKeywordValue`. * Add changes according to the PR review. Bit-Quill#180 * Update `IndexMapping::parseMapping` function. * Add `OpenSearchDataType::resolve` function. * Add new constructor for `OpenSearchTextType`. * Make `fields` and `properties` in `OpenSearchDataType` readonly. Update tests and mapping parser. * Move `getFields` from `OpenSearchDataType` to `OpenSearchTextType`. Update tests. * Rewrite `traverseAndFlatten` according to Bit-Quill#180 (comment) * Minor comment fix. * A fix to avoid breaking changes. * `typeName` and `legacyTypeName` to return different type names. * Change `typeof` function and corresponding tests. * Move `convertTextToKeyword` from `ScriptUtils` to `OpenSearchTextType`. Update tests. * Update UT for `typeof` function. * Make all instances of `OpenSearchDataType` and of derived types singletones as much as possible. * Make string representations of all `ExprType`s uppercase. * Remove functions from `IndexMapping` used in tests only. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> (cherry picked from commit d44cd39) Co-authored-by: Yury-Fridlyand <[email protected]>
…search-project#247) (opensearch-project#1457) (opensearch-project#1459) * Changed pow and power to return null when an invalid response would be returned and added missing integration tests for the pow and power function. Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit a35f963) Co-authored-by: Matthew Wells <[email protected]>
…) (opensearch-project#1472) * Add `Timestampdiff` Function To OpenSearch SQL Added Tests And Implementation For Timestampdiff --------- Signed-off-by: GabeFernandez310 <[email protected]> * Removed Import Signed-off-by: GabeFernandez310 <[email protected]> --------- Signed-off-by: GabeFernandez310 <[email protected]> (cherry picked from commit 31148da) Co-authored-by: GabeFernandez310 <[email protected]>
) Signed-off-by: vamsi-amazon <[email protected]>
…pensearch-project#2560) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit d11a268)
…h-project#2562) * Add vacuum operation and IT * Add index state doc delete and more IT * Refactor IT * Fix bytebuddy version conflict * Fix broken IT * Fix broken IT * Fix jacoco failure with new IT * Fix code format * Fix jacoco test coverage --------- (cherry picked from commit 8374cb6) Signed-off-by: Chen Dai <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rch-project#2563) * Change aysnc_query default setting * fix doctest --------- (cherry picked from commit b375a28) Signed-off-by: Peng Huo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…earch-project#2566) * percent encode opensearch index name * spec test vacuum * spotlessApply --------- (cherry picked from commit e17962f) Signed-off-by: Sean Kao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Refactor query param * Reduce scope of changes --------- (cherry picked from commit ee2dbd5) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…opensearch-project#2567) (cherry picked from commit b3fc1ca) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch-project#2569) (cherry picked from commit 405068b) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…opensearch-project#2575) (cherry picked from commit 284a0be) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nsearch-project#2571) (cherry picked from commit 4dc83b7) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…h-project#2580) (cherry picked from commit a67de21) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…earch-project#2582) (opensearch-project#2583) (cherry picked from commit 85dae6f) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#2577) (opensearch-project#2589) (cherry picked from commit bfcaedf) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) (opensearch-project#2592) * escape query in spark submit parameter Signed-off-by: Sean Kao <[email protected]> * spotless Signed-off-by: Sean Kao <[email protected]> * test case for special character Signed-off-by: Sean Kao <[email protected]> --------- Signed-off-by: Sean Kao <[email protected]> (cherry picked from commit 2bcf0b8)
…arch-project#2595) (cherry picked from commit e153609) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…h-project#2607) (cherry picked from commit 36b423c) Signed-off-by: Chen Dai <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ensearch-project#2615) (opensearch-project#2618) (cherry picked from commit 204c7da) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oject#2613) (cherry picked from commit 2649200) Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oject#2627) (cherry picked from commit 0d8341f) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…-project#2441) (opensearch-project#2629) (cherry picked from commit 3f53904) Signed-off-by: Andreas Kulicke <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…opensearch-project#2608) (cherry picked from commit 39c0222) Signed-off-by: Adi Suresh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…search-project#2633) * update sql grammar files from upstream * resolve semicolon cause incorrect parsing * spotlessApply --------- (cherry picked from commit 7f8fbe9) Signed-off-by: Sean Kao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…error (opensearch-project#2626) (opensearch-project#2634) (cherry picked from commit 5464bfc) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]>
…ensearch-project#2635) Instead of downloading the JAR from Maven, the JAR in the EMR serverless root file system can be used. (cherry picked from commit e578a57) Signed-off-by: Adi Suresh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ect#2648) (cherry picked from commit b454a2c) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oject#2624) (opensearch-project#2639) * Add option to use LakeFormation in S3Glue data source. * Update s3glue_connector.rst corrected formatting issue. --------- (cherry picked from commit ea08c8f) Signed-off-by: Adi Suresh <[email protected]> Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vamsi Manohar <[email protected]>
…#2664) (cherry picked from commit cfd222c) Signed-off-by: Sean Kao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nsearch-project#2667) * Delete Spark datasource (opensearch-project#2638) * Delete Spark datasource Signed-off-by: Tomoyuki Morita <[email protected]> * Fix build error Signed-off-by: Tomoyuki Morita <[email protected]> * Delete spark_connector.rst Signed-off-by: Tomoyuki Morita <[email protected]> * Add missing test Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit de7b367) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix test failure in DefaultSparkSqlFunctionResponseHandleTest Signed-off-by: Tomoyuki Morita <[email protected]> * Reformat Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.