Refactor query param #2519
Merged
Refactor query param #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noCharger
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2519 +/- ##
============================================
+ Coverage 95.42% 95.43% +0.01%
- Complexity 5027 5031 +4
============================================
Files 483 484 +1
Lines 14020 14034 +14
Branches 944 940 -4
============================================
+ Hits 13378 13394 +16
+ Misses 621 619 -2
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Confirmed the BWC failure unrelated to this PR by reproducing the same issue with a shadow PR checked from main branch https://github.com/opensearch-project/sql/actions/runs/7894433419/job/21545080478?pr=2520 |
noCharger
force-pushed
the
refactor-query-param
branch
from
dec7bb8 to
0a8ba80
Compare
This was referenced Mar 10, 2024
noCharger
force-pushed
the
refactor-query-param
branch
from
0a8ba80 to
ca3d66e
Compare
Signed-off-by: Louis Chu <[email protected]>
noCharger
force-pushed
the
refactor-query-param
branch
3 times, most recently
from
1cc9819 to
7592f7a
Compare
penghuo
previously approved these changes
Mar 12, 2024
Signed-off-by: Louis Chu <[email protected]>
noCharger
force-pushed
the
refactor-query-param
branch
from
7592f7a to
7c86b3a
Compare
dai-chen
approved these changes
Mar 13, 2024
penghuo
approved these changes
Mar 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Refactor query param Signed-off-by: Louis Chu <[email protected]> * Reduce scope of changes Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit ee2dbd5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
documenting some findings on an issue with batch flint job on EMR-S after this PR. Batch job submitted to EMR-S will fail. For clearer error message, modified this line: From the error message, perhaps it has something to do with how EMR parse the Spark Submit Parameters The entire stderr file for the batch jobExample 1: Example 2: |
after wrapping the query with quotes, job succeeds |
noCharger
added a commit
to noCharger/sql
that referenced
this pull request
Mar 19, 2024
* Refactor query param Signed-off-by: Louis Chu <[email protected]> * Reduce scope of changes Signed-off-by: Louis Chu <[email protected]> --------- Signed-off-by: Louis Chu <[email protected]>
penghuo
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Refactor query param * Reduce scope of changes --------- (cherry picked from commit ee2dbd5) Signed-off-by: Louis Chu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
spark/src/main/java/org/opensearch/sql/spark/client/StartJobRequest.javaintospark/src/main/java/org/opensearch/sql/spark/asyncquery/model/SparkSubmitParameters.javato avoid input limitation from EMRSIssues Resolved
#2376
Check List
New functionality has been documented.New functionality has javadoc addedNew functionality has user manual doc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.