Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add Timestampdiff Function To OpenSearch SQL #1472

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 31148da from #1467

* Add `Timestampdiff` Function To OpenSearch SQL

Added Tests And Implementation For Timestampdiff

---------

Signed-off-by: GabeFernandez310 <[email protected]>

* Removed Import

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 31148da)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 24, 2023 20:20
@codecov-commenter
Copy link

Codecov Report

Merging #1472 (b9a568b) into 2.x (49a82ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x    #1472   +/-   ##
=========================================
  Coverage     98.46%   98.46%           
- Complexity     3848     3863   +15     
=========================================
  Files           345      345           
  Lines          9554     9594   +40     
  Branches        615      615           
=========================================
+ Hits           9407     9447   +40     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...pensearch/sql/sql/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rupal-bq rupal-bq added the enhancement New feature or request label Mar 24, 2023
@rupal-bq rupal-bq merged commit 20964e1 into 2.x Mar 24, 2023
@github-actions github-actions bot deleted the backport/backport-1467-to-2.x branch March 24, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants