-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percent encode opensearch index name #2564
Percent encode opensearch index name #2564
Conversation
Signed-off-by: Sean Kao <[email protected]>
It might cause parsing issue. Let's sync up offline. |
spark/src/test/java/org/opensearch/sql/spark/asyncquery/IndexQuerySpecTest.java
Show resolved
Hide resolved
sure I get your concern. Will test if spark submit parameters can parse the backtick stuff Edit: |
Signed-off-by: Sean Kao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2564 +/- ##
=========================================
Coverage 95.50% 95.50%
- Complexity 5113 5117 +4
=========================================
Files 489 489
Lines 14310 14318 +8
Branches 961 963 +2
=========================================
+ Hits 13667 13675 +8
Misses 618 618
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sean Kao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
* percent encode opensearch index name Signed-off-by: Sean Kao <[email protected]> * spec test vacuum Signed-off-by: Sean Kao <[email protected]> * spotlessApply Signed-off-by: Sean Kao <[email protected]> --------- Signed-off-by: Sean Kao <[email protected]> (cherry picked from commit e17962f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* percent encode opensearch index name * spec test vacuum * spotlessApply --------- (cherry picked from commit e17962f) Signed-off-by: Sean Kao <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Handle special characters when generating Flint index name by percent-encoding the invalid OpenSearch index name characters, since in some cases, sql queries (DROP, ALTER) are handled over here rather than forwarded to spark.
Same fix in opensearch-spark repo: opensearch-project/opensearch-spark#215
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.