Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EXTRACT Function To OpenSearch SQL Plugin #1421

Merged

Conversation

GabeFernandez310
Copy link
Contributor

Description

Adds the EXTRACT function to the SQL plugin, aligned with the MySQL documentation. Extract(part FROM date) returns a number formatted according to what is defined by the temporal interval being used for the part argument. A list of the MySQL temporal intervals can be found here.

Example:
Extract(DAY FROM "2023-02-11 10:11:12.123") -> 11
Extract(DAY SECOND_MICROSECOND "2023-02-11 10:11:12.123") -> 12123000

Issues Resolved

722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Added Basic Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Lexer And Parser Language

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Implementation And Fixed Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Documentation

Signed-off-by: GabeFernandez310 <[email protected]>

* Modified Implementation And Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle Issues

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Javadoc comments and Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed A Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Integration Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Refactored Extract Tests Into New File

Signed-off-by: GabeFernandez310 <[email protected]>

* Refactored Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Renamed Rule In Parser

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed AstExpressionBuilder

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner March 10, 2023 16:14
@codecov-commenter
Copy link

Codecov Report

Merging #1421 (1a351d6) into main (ef38389) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1421   +/-   ##
=========================================
  Coverage     98.38%   98.39%           
- Complexity     3698     3706    +8     
=========================================
  Files           343      343           
  Lines          9121     9169   +48     
  Branches        586      586           
=========================================
+ Hits           8974     9022   +48     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...sql/expression/datetime/DateTimeFormatterUtil.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...pensearch/sql/sql/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

acarbonetto
acarbonetto previously approved these changes Mar 13, 2023
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@GabeFernandez310 GabeFernandez310 requested review from Yury-Fridlyand and removed request for penghuo and dai-chen March 15, 2023 22:29
@dai-chen dai-chen merged commit 87018c6 into opensearch-project:main Mar 16, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1421-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 87018c654ed648615984071203fa9016d4c414f5
# Push it to GitHub
git push --set-upstream origin backport/backport-1421-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1421-to-2.x.

GabeFernandez310 added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Mar 16, 2023
)

* Add `EXTRACT` Function To OpenSearch SQL Plugin

* Added Basic Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Lexer And Parser Language

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Implementation And Fixed Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Documentation

Signed-off-by: GabeFernandez310 <[email protected]>

* Modified Implementation And Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle Issues

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Javadoc comments and Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed A Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Integration Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Refactored Extract Tests Into New File

Signed-off-by: GabeFernandez310 <[email protected]>

* Refactored Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Renamed Rule In Parser

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed AstExpressionBuilder

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>

* Removed Unneeded Code And Added Parser Test

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 87018c6)
Yury-Fridlyand pushed a commit that referenced this pull request Mar 16, 2023
* Add `EXTRACT` Function To OpenSearch SQL Plugin

* Added Basic Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Lexer And Parser Language

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Implementation And Fixed Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Documentation

Signed-off-by: GabeFernandez310 <[email protected]>

* Modified Implementation And Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle Issues

Signed-off-by: GabeFernandez310 <[email protected]>

* Added Javadoc comments and Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed Implementation

Signed-off-by: GabeFernandez310 <[email protected]>

* Changed A Test

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Integration Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Refactored Extract Tests Into New File

Signed-off-by: GabeFernandez310 <[email protected]>

* Refactored Tests

Signed-off-by: GabeFernandez310 <[email protected]>

* Renamed Rule In Parser

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed AstExpressionBuilder

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>

* Removed Unneeded Code And Added Parser Test

Signed-off-by: GabeFernandez310 <[email protected]>

---------

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 87018c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants