Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_day Function To OpenSearch SQL Plugin #1344

Merged

Conversation

GabeFernandez310
Copy link
Contributor

@GabeFernandez310 GabeFernandez310 commented Feb 15, 2023

Description

Adds the last_day function to the SQL plugin according to MySQL documentation. It returns a DATE for the last day of the given month based on the input argument.

Examples:

opensearchsql> SELECT last_day('2020-02-03');
fetched rows / total rows = 1/1
+--------------------------+
| last_day('2020-02-03')   |
|--------------------------|
| 2020-02-29               |
+--------------------------+
opensearchsql> SELECT last_day('2021-02-03 10:11:12');
fetched rows / total rows = 1/1
+-----------------------------------+
| last_day('2021-02-03 10:11:12')   |
|-----------------------------------|
| 2021-02-28                        |
+-----------------------------------+

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Added Testing And Implementation

---------

Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner February 15, 2023 16:40
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #1344 (32a5124) into main (72547f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1344   +/-   ##
=========================================
  Coverage     98.36%   98.37%           
- Complexity     3643     3655   +12     
=========================================
  Files           343      343           
  Lines          9010     9032   +22     
  Branches        585      585           
=========================================
+ Hits           8863     8885   +22     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the enhancement New feature or request label Feb 16, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit d9114f5 into opensearch-project:main Feb 16, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 16, 2023
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit d9114f5)
penghuo pushed a commit that referenced this pull request Feb 16, 2023
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit d9114f5)

Co-authored-by: GabeFernandez310 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants