Added Arithmetic functions to V2 engine #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1416 +/- ##
=========================================
Coverage 98.38% 98.38%
- Complexity 3698 3701 +3
=========================================
Files 343 343
Lines 9121 9124 +3
Branches 586 586
=========================================
+ Hits 8974 8977 +3
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine Signed-off-by: Matthew Wells <[email protected]>
matthewryanwells
force-pushed
the
integ-arithmetic
branch
from
9458adc to
18b0e8b
Compare
matthewryanwells
changed the title
Yury-Fridlyand
previously approved these changes
Mar 10, 2023
MaxKsyunz
previously approved these changes
Mar 11, 2023
10 tasks
matthewryanwells
dismissed stale reviews from MaxKsyunz and Yury-Fridlyand
via
ebbeb25
Signed-off-by: Matthew Wells <[email protected]>
Yury-Fridlyand
previously approved these changes
Mar 15, 2023
|
Please resolve the conflicts. |
Signed-off-by: Matthew Wells <[email protected]>
dai-chen
approved these changes
Mar 16, 2023
Yury-Fridlyand
approved these changes
Mar 16, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Updated Arithmetic functions from old engine to new engine (#235) * Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit bc39346)
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Updated Arithmetic functions from old engine to new engine (#235) * Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit bc39346) Co-authored-by: Matthew Wells <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added ADD, SUBTRACT, MULTIPLY, DIVIDE, and MODULUS to the new engine, as well as moved MOD from mathematical functions to arithmetics
Issues Resolved
#1190
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.