-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change async query default setting #2561
Merged
penghuo
merged 2 commits into
opensearch-project:main
from
penghuo:changeDefaultSettings
Mar 19, 2024
Merged
Change async query default setting #2561
penghuo
merged 2 commits into
opensearch-project:main
from
penghuo:changeDefaultSettings
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <[email protected]>
penghuo
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
March 19, 2024 00:20
YANG-DB
previously approved these changes
Mar 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2561 +/- ##
============================================
+ Coverage 95.47% 95.53% +0.05%
- Complexity 5046 5101 +55
============================================
Files 486 488 +2
Lines 14087 14261 +174
Branches 943 958 +15
============================================
+ Hits 13450 13624 +174
Misses 614 614
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vamsimanohar
previously approved these changes
Mar 19, 2024
Signed-off-by: Peng Huo <[email protected]>
dai-chen
approved these changes
Mar 19, 2024
vamsimanohar
approved these changes
Mar 19, 2024
noCharger
approved these changes
Mar 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Change aysnc_query default setting Signed-off-by: Peng Huo <[email protected]> * fix doctest Signed-off-by: Peng Huo <[email protected]> --------- Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit b375a28) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Change aysnc_query default setting * fix doctest --------- (cherry picked from commit b375a28) Signed-off-by: Peng Huo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#2471
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.