Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change async query default setting #2561

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Mar 19, 2024

Description

  • plugins.query.executionengine.spark.session.limit, 100 to 10
  • plugins.query.executionengine.spark.refresh_job.limit, 20 to 5
  • plugins.query.executionengine.spark.session.index.ttl, 14 day to 30 day

Issues Resolved

#2471

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

YANG-DB
YANG-DB previously approved these changes Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (a84c3ef) to head (eb6efa9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2561      +/-   ##
============================================
+ Coverage     95.47%   95.53%   +0.05%     
- Complexity     5046     5101      +55     
============================================
  Files           486      488       +2     
  Lines         14087    14261     +174     
  Branches        943      958      +15     
============================================
+ Hits          13450    13624     +174     
  Misses          614      614              
  Partials         23       23              
Flag Coverage Δ
sql-engine 95.53% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vamsimanohar
vamsimanohar previously approved these changes Mar 19, 2024
@vamsimanohar vamsimanohar added the v2.13.0 Issues targeting release v2.13.0 label Mar 19, 2024
Signed-off-by: Peng Huo <[email protected]>
@penghuo penghuo dismissed stale reviews from vamsimanohar and YANG-DB via eb6efa9 March 19, 2024 02:30
@penghuo penghuo merged commit b375a28 into opensearch-project:main Mar 19, 2024
27 of 28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 19, 2024
* Change aysnc_query default setting

Signed-off-by: Peng Huo <[email protected]>

* fix doctest

Signed-off-by: Peng Huo <[email protected]>

---------

Signed-off-by: Peng Huo <[email protected]>
(cherry picked from commit b375a28)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Mar 19, 2024
* Change aysnc_query default setting



* fix doctest



---------


(cherry picked from commit b375a28)

Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x v2.13.0 Issues targeting release v2.13.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants