-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iceberg support to EMR serverless jobs. #2602
Conversation
@asuresh8 can we add more details in description. What is iceberg and why are we adding this? |
Add more details to description |
Could you please add screeen shots or alteast mention the scenarios that we have tested. |
spark/src/test/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcherTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2602 +/- ##
=========================================
Coverage 95.37% 95.37%
Complexity 5131 5131
=========================================
Files 490 490
Lines 14428 14430 +2
Branches 968 968
=========================================
+ Hits 13760 13762 +2
Misses 643 643
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Adi Suresh <[email protected]>
Signed-off-by: Adi Suresh <[email protected]> (cherry picked from commit 39c0222) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 39c0222) Signed-off-by: Adi Suresh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This commit adds support for query workbench to access Iceberg tables. Iceberg is a commonly used table format for data stored on S3. Specifically, security lake data is stored in Iceberg format. This change enables security lake data to be queried using query workbench.
Testing
Built and deployed to cluster and then queried Hive, and Iceberg tables to verify functionality still works as well as testing the new functionality.
First round of testing to make sure Flint is compatible is in opensearch-project/opensearch-spark#301
End to end test using this package was performed with following steps:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.