Incorporate BreachAlertsManager in to LoginsListViewController #6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
* main: [String Update] - Updated string formatting at various places in the app (#6919) Refactor Today widget to MVVM architecture : viewModel and model files added (#6864) fix #6816: update sync telemetry message format (#6914) [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
* main: Fix #6846 - Added event to track start search button press (#6931) Bugzilla 1649159: RTL char bug in downloaded file name (#6942) [String Update] - Updated string formatting at various places in the app (#6919) Refactor Today widget to MVVM architecture : viewModel and model files added (#6864) fix #6816: update sync telemetry message format (#6914) [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
vphong
force-pushed
the
vphong/breachalerts-ui
branch
from
4a85c16
to
88b49e7
Compare
vphong
commented
Jul 10, 2020
kaylagalway
reviewed
Jul 15, 2020
kaylagalway
approved these changes
Jul 15, 2020
vphong
added a commit
that referenced
this pull request
Jul 16, 2020
…le/firefox-ios into vphong/breachalerts * 'vphong/breachalerts' of https://github.com/mozilla-mobile/firefox-ios: Fix #6948 - Crash after rearranged folder and pressing save button (#6980) Incorporate BreachAlertsManager in to LoginsListViewController (#6934)
vphong
added a commit
that referenced
this pull request
Jul 16, 2020
* vphong/breachalerts: Fix #6948 - Crash after rearranged folder and pressing save button (#6980) Incorporate BreachAlertsManager in to LoginsListViewController (#6934) Fix #6893 - Added new tab open button for landscape UI (#6947) Tint the default favicon white when in dark mode (#6873) Update release_checklist_template.md (#6970) Bug 1644846 - Migrate legacy telemetry to Glean (#6912) Create new_issues_to_project.yml Fix #6626: re-create the logins db on failure to open (#6952) Wrap long text in ETP message in action sheet popup (#6869) For #6495 - XCUITest sync int disconnect and connect same account to … (#6913) Bug 1595808 - Update decision image. r=tomprince (#6954) Removed LP Setup in hidden menu that got added twice (#6951)
vphong
added a commit
that referenced
this pull request
Aug 17, 2020
* Base BreachAlertsManager with loadBreaches() and compareToBreaches() (#6696) * Revert "Base BreachAlertsManager with loadBreaches() and compareToBreaches() (#6696)" (#6698) This reverts commit 6110fd0. * Base BreachAlertsManager class with loadBreaches() + compare() (#6699) * Test BreachAlertsManager.loadBreaches() and compareToBreaches() (#6715) * Refactor LoginListViewController to MVVM (#6779) * Refactor LoginListViewController to MVVM (again) (#6871) * Refactor LoginListViewController to MVVM * New PR made because previous changes were not merged correctly * Test LoginsList-related refactored classes (#6897) * LoginsList test stubs * fix test db deletion * query test * more view model tests * test on properties set by setLogins * open logins db * LoginListSelectionHelper tests * VM helper tests * headers * Delete LoginListDataSourceHelper.swift * queue-ify loadLogins * queue-ify tests * computeSectionsFromLogin + revert queues * remove tests requiring loadLogins to be called + cleanup * review changes * cleanup after renaming * Incorporate BreachAlertsManager in to LoginsListViewController (#6934) * Add breach alert icon to Logins List cells and display if item is breached (#6992) * basic BreachAlerts surfacing * UI update for breaches * record breach IndexPaths * rewrite findUserBreaches * findUserBreaches refinement * reload table after breaches are loaded to update UI * rework cell reload method * review changes * rudimentary asset display * positioning using custom cell * hide icon and show when needed * refinement * positioning, vector size, additional mock data * cleanup * bug cleanup/polish * convert array to set for performance * forEach reloadRows optimization * margins + breach reload optimization Co-authored-by: Garvan Keeley <[email protected]> Co-authored-by: Nishant Bhasin <[email protected]> * Fix margins within LoginListTableViewCell (#7022) * Update LoginListTableViewCell.swift and add custom stack views + containers * FXIOS-710 ⁃ Create breach details view (#7041) * stubbing * stack views * convert [BreachRecord] to set; basic view population * formatting + string population * UI polish * commenting * button implementation * breach link malformation handling * VoiceOver support * more elegant url handling * use delegate * better delegation * setup function for breach detail view * re-add long login * tests + comments + better accessibility support * spacing + mock data redo * UX updates (#7127) * FXIOS-731 ⁃ HTTP HEAD etags to cut down on data requests from Breach Alerts (#7100) * first pass * etag & last accessed date integration * test compatibility * better completion handling * cleanup * review 1 * review 2 * Update BreachAlertsManager.swift * formatting/test reformation * fix logic errors * Update BreachAlertsManager.swift * fix logic * remove mock data * Lint Co-authored-by: Garvan Keeley <[email protected]> Co-authored-by: isabelrios <[email protected]> Co-authored-by: isabel rios <[email protected]> Co-authored-by: Daniela Arcese <[email protected]> Co-authored-by: Vlad Dramaretskyi <[email protected]> Co-authored-by: Haris Zaman <[email protected]> Co-authored-by: noorhashem <[email protected]> Co-authored-by: Edouard Oger <[email protected]> Co-authored-by: Kayla Galway <[email protected]> Co-authored-by: Nishant Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6695. Improves the
findUserBreaches()to look up breaches faster than a double for loop. Updates the UITableViewController to display red text on breached logins. Preview:Simulator Screen Shot - iPhone SE (2nd generation) - 2020-07-10 at 14 31 40