Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #6495 - XCUITest sync int disconnect and connect same account to … #6913

Conversation

isabelrios
Copy link
Contributor

@isabelrios isabelrios commented Jul 6, 2020

…verify data synced

Fixes #6495
What the test does:
-On desktop there is one bookmark and one login.
-On mobile:
-- Sign in using same account
-- Check bookmark and login
-- Disconnect account
-- Connect account again
-- Check bookmark and login are still there

@isabelrios isabelrios force-pushed the Issue6495-XCUITestDisconnecConnectBookmarkLogin branch from eaba468 to 84af1e6 Compare July 6, 2020 16:59
@isabelrios
Copy link
Contributor Author

@garvankeeley we are finally unblocked to have this test working to check data after disconnecting and connecting a fx account.
This test will check login and bookmark entries, would that be fine for you or do you have any other preference?
Once we see this is running stable we could create new tests to check history/tabs under the same disconnect/connect scneario.

@garvankeeley
Copy link
Contributor

I think logins and bookmark sounds like it would be enough to cover most potential problem cases.

@isabelrios isabelrios merged commit dbc0ea2 into mozilla-mobile:main Jul 13, 2020
dnarcese pushed a commit to dnarcese/firefox-ios that referenced this pull request Jul 14, 2020
…me account to … (mozilla-mobile#6913)

* For mozilla-mobile#6495 - XCUITest sync int disconnect and connect same account to verify data synced

* remove reference to history entry for now
vphong added a commit that referenced this pull request Jul 16, 2020
* main:
  Fix #6893 - Added new tab open button for landscape UI (#6947)
  Tint the default favicon white when in dark mode (#6873)
  Update release_checklist_template.md (#6970)
  Bug 1644846 - Migrate legacy telemetry to Glean (#6912)
  Create new_issues_to_project.yml
  Fix #6626: re-create the logins db on failure to open (#6952)
  Wrap long text in ETP message in action sheet popup (#6869)
  For #6495 - XCUITest sync int disconnect and connect same account to … (#6913)
  Bug 1595808 - Update decision image. r=tomprince (#6954)
  Removed LP Setup in hidden menu that got added twice (#6951)
vphong added a commit that referenced this pull request Jul 16, 2020
* vphong/breachalerts:
  Fix #6948 - Crash after rearranged folder and pressing save button (#6980)
  Incorporate BreachAlertsManager in to LoginsListViewController (#6934)
  Fix #6893 - Added new tab open button for landscape UI (#6947)
  Tint the default favicon white when in dark mode (#6873)
  Update release_checklist_template.md (#6970)
  Bug 1644846 - Migrate legacy telemetry to Glean (#6912)
  Create new_issues_to_project.yml
  Fix #6626: re-create the logins db on failure to open (#6952)
  Wrap long text in ETP message in action sheet popup (#6869)
  For #6495 - XCUITest sync int disconnect and connect same account to … (#6913)
  Bug 1595808 - Update decision image. r=tomprince (#6954)
  Removed LP Setup in hidden menu that got added twice (#6951)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FXIOS-384 ⁃ Test case needed for disconnect and reconnect FxA
3 participants