Fix #6948 - Crash after rearranged folder and pressing save button #6980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnarcese
approved these changes
Jul 15, 2020
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
vphong
added a commit
that referenced
this pull request
Jul 16, 2020
…le/firefox-ios into vphong/breachalerts * 'vphong/breachalerts' of https://github.com/mozilla-mobile/firefox-ios: Fix #6948 - Crash after rearranged folder and pressing save button (#6980) Incorporate BreachAlertsManager in to LoginsListViewController (#6934)
vphong
added a commit
that referenced
this pull request
Jul 16, 2020
* vphong/breachalerts: Fix #6948 - Crash after rearranged folder and pressing save button (#6980) Incorporate BreachAlertsManager in to LoginsListViewController (#6934) Fix #6893 - Added new tab open button for landscape UI (#6947) Tint the default favicon white when in dark mode (#6873) Update release_checklist_template.md (#6970) Bug 1644846 - Migrate legacy telemetry to Glean (#6912) Create new_issues_to_project.yml Fix #6626: re-create the logins db on failure to open (#6952) Wrap long text in ETP message in action sheet popup (#6869) For #6495 - XCUITest sync int disconnect and connect same account to … (#6913) Bug 1595808 - Update decision image. r=tomprince (#6954) Removed LP Setup in hidden menu that got added twice (#6951)
|
These checks look important to add, thanks. I don't see what the crash was from looking at this change, was it an exception thrown from the DB because we were doing an illegal change? |
|
Actually after taking in the from background to foreground, it froze for 3 seconds and crashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6948
Before:
With this commit: