Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXIOS-568 ⁃ New Tab Button UI (landscape) #6893

Closed
athomasmoz opened this issue Jun 30, 2020 · 3 comments · Fixed by #6947
Closed

FXIOS-568 ⁃ New Tab Button UI (landscape) #6893

athomasmoz opened this issue Jun 30, 2020 · 3 comments · Fixed by #6947
Assignees
@nbhasin2
Labels
1 Story size 2 Story size QA Verified Issue verified by QA

Comments

@athomasmoz
Copy link

athomasmoz commented Jun 30, 2020 •
edited by data-sync-user
Loading

Vision

As a user viewing a webpage, I want a button to start a brand new search in a new tab so that I can quick start another search while keeping my current tab open for later

Acceptance Criteria

  • A new tab button has been added to nav bar in landscape mode spec (landscape only)
    • New tab button on toolbar in landscape mode
    • Button opens to a new tab with the keyboard up, ready to type in URL bar
  • Ensure a11y standards are met

Not included

┆Issue is synchronized with this Jira Task
@athomasmoz athomasmoz added the 2 Story size label Jun 30, 2020
This was referenced Jun 30, 2020
Closed
Closed
@athomasmoz athomasmoz changed the title New Tab Button UI New Tab Button UI (landscape) Jul 2, 2020
kaylagalway pushed a commit that referenced this issue Jul 6, 2020
@nbhasin2
[String Update] #6893: Added accessibility string for New Tab Button …
e2322b1 
…UI (#6910)
vphong added a commit that referenced this issue Jul 7, 2020
@vphong
Merge branch 'main' into vphong/loginslist-tests
6a71161 
* main:
  fix #6816: update sync telemetry message format (#6914)
  [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
  For #6900 - Update A-s to 61.0.7 (#6901)
  [Today Widget] added strings (#6906)
@nbhasin2 nbhasin2 self-assigned this Jul 8, 2020
vphong added a commit that referenced this issue Jul 8, 2020
@vphong
Merge branch 'main' into vphong/breachalerts-ui
7435ffb 
* main:
  [String Update] - Updated string formatting at various places in the app (#6919)
  Refactor Today widget to MVVM architecture : viewModel and model files added (#6864)
  fix #6816: update sync telemetry message format (#6914)
  [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
vphong added a commit that referenced this issue Jul 10, 2020
@vphong
Merge branch 'main' into vphong/breachalerts
ed401b3 
* main:
  Fix #6846 - Added event to track start search button press (#6931)
  Bugzilla 1649159: RTL char bug in downloaded file name (#6942)
  [String Update] - Updated string formatting at various places in the app (#6919)
  Refactor Today widget to MVVM architecture : viewModel and model files added (#6864)
  fix #6816: update sync telemetry message format (#6914)
  [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
@nbhasin2 nbhasin2 linked a pull request Jul 14, 2020 that will close this issue
Fix #6893 - Added new tab open button for landscape UI #6947
Merged
@jevans-mozilla jevans-mozilla added the 1 Story size label Jul 14, 2020
dnarcese pushed a commit to dnarcese/firefox-ios that referenced this issue Jul 14, 2020
@nbhasin2 @dnarcese
[String Update] mozilla-mobile#6893: Added accessibility string for N…
cc1d655 
…ew Tab Button UI (mozilla-mobile#6910)
nbhasin2 added a commit that referenced this issue Jul 15, 2020
@nbhasin2
Fix #6893 - Added new tab open button for landscape UI (#6947)
340e7b5 
- Update TabToolbarHelperTests.swift
- Added accessibility label and also did some cleanup
@nbhasin2
Copy link
Contributor

@isabelrios @SimonBasca I did a local accessibility test on my simulator and things seemed fine. If you find anything related to ➕ button on the URL bar in landscape mode do let me.

@SimonBasca
Copy link
Contributor

Verified fixed.
Tested on iPhone Xr (13.5), iPhone SE (11.4), iPhone 8 (13.5), iPad Pro 3rd gen (13.4) on main 340e7b5.

@SimonBasca SimonBasca added the QA Verified Issue verified by QA label Jul 16, 2020
@SimonBasca
Copy link
Contributor

@nbhasin2 I found this minor issue related to the New Tab Button UI (landscape) #6987. Feel free to close it if you feel that it's not an issue.

vphong added a commit that referenced this issue Jul 16, 2020
@vphong
Merge branch 'main' into vphong/breachalerts
eda4a55 
* main:
  Fix #6893 - Added new tab open button for landscape UI (#6947)
  Tint the default favicon white when in dark mode (#6873)
  Update release_checklist_template.md (#6970)
  Bug 1644846 - Migrate legacy telemetry to Glean (#6912)
  Create new_issues_to_project.yml
  Fix #6626: re-create the logins db on failure to open (#6952)
  Wrap long text in ETP message in action sheet popup (#6869)
  For #6495 - XCUITest sync int disconnect and connect same account to … (#6913)
  Bug 1595808 - Update decision image. r=tomprince (#6954)
  Removed LP Setup in hidden menu that got added twice (#6951)
vphong added a commit that referenced this issue Jul 16, 2020
@vphong
Merge branch 'vphong/breachalerts' into vphong/breachalerts-assets
6e462e7 
* vphong/breachalerts:
  Fix #6948 - Crash after rearranged folder and pressing save button (#6980)
  Incorporate BreachAlertsManager in to LoginsListViewController (#6934)
  Fix #6893 - Added new tab open button for landscape UI (#6947)
  Tint the default favicon white when in dark mode (#6873)
  Update release_checklist_template.md (#6970)
  Bug 1644846 - Migrate legacy telemetry to Glean (#6912)
  Create new_issues_to_project.yml
  Fix #6626: re-create the logins db on failure to open (#6952)
  Wrap long text in ETP message in action sheet popup (#6869)
  For #6495 - XCUITest sync int disconnect and connect same account to … (#6913)
  Bug 1595808 - Update decision image. r=tomprince (#6954)
  Removed LP Setup in hidden menu that got added twice (#6951)
@data-sync-user data-sync-user changed the title New Tab Button UI (landscape) FXIOS-568 ⁃ New Tab Button UI (landscape) Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbhasin2 nbhasin2

Labels
1 Story size 2 Story size QA Verified Issue verified by QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6893 - Added new tab open button for landscape UI
4 participants
@nbhasin2 @SimonBasca @athomasmoz @jevans-mozilla