-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6846 - Added event to track start search button press #6931
Fix #6846 - Added event to track start search button press #6931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
Tagging @chutten for data review |
Please fill out the required form from here before requesting review from a data steward. For an example of what a filled data review request should look like, see here: https://bugzilla.mozilla.org/show_bug.cgi?id=1635427 or here: mozilla-lockwise/lockwise-android#1196 (comment) |
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
This in turn should increase the searches performed by the user as tapping the button takes user to the addressbar which is where user starts a search or goes to another website.
This is a new button and we don't have any metrics for it to measure.
Not really as this button is just added so current instrumentation cannot determine the number of times user taps on the button. One could say we can tap into search analytics but then again it doesn't tie with the new button thats added right now.
Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
All users
In Firefox iOS there is a preference for telemetry labeled "Send Usage Data" that will be used as the opt-out mechanism.
We will look at how many times user taps on the new start search button and b/w v27 to upcoming v28 if we see increase in search traffic.
Mozilla internal channels with our PM
No 3rd party tool |
@travis79 Could I request review on the above form and see if I am missing anything |
@nbhasin2 Looks good on everything but two items:
|
PRELIMINARY NOTES There is no individual listed as responsible for this collection. Collections that do not automatically expire require an individual responsible for them. I will assume @nbhasin2 is responsible. DATA COLLECTION REVIEW RESPONSE:
Yes. This collection is can be controlled through Firefox's Preferences.
Yes, @nbhasin2 is responsible.
Category 2, Interaction.
Default on for all channels.
No.
Yes.
No. This collection is permanent. Result: datareview+ |
Will take responsibility for this @chutten, thank you :) |
Tagging @garvankeeley for final code review |
…mobile/firefox-ios into vphong/loginslist-tests * 'vphong/loginslist-tests' of https://github.com/mozilla-mobile/firefox-ios: Fix #6846 - Added event to track start search button press (#6931)
* main: Fix #6846 - Added event to track start search button press (#6931) Bugzilla 1649159: RTL char bug in downloaded file name (#6942) [String Update] - Updated string formatting at various places in the app (#6919) Refactor Today widget to MVVM architecture : viewModel and model files added (#6864) fix #6816: update sync telemetry message format (#6914) [String Update] #6893: Added accessibility string for New Tab Button UI (#6910)
…ess (mozilla-mobile#6931) * Fix mozilla-mobile#6846 - Added event to track start search button press * Updated telemetry doc
Migrates legacy telemetry to Glean metrics. Renames UnifiedTelemetry to TelemetryWrapper to clarify its purpose. Add start search button pressed Glean counter metric similar to PR mozilla-mobile#6931. Update to Glean v31.3.0
Migrates legacy telemetry to Glean metrics. Renames UnifiedTelemetry to TelemetryWrapper to clarify its purpose. Add start search button pressed Glean counter metric similar to PR #6931. Update to Glean v31.3.0
No description provided.